Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

[Security] Empty Admin Credentials Still Allow Forged Admin JWTs

Aperta
  • Qualcosa non va?
#320 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-3 ore
Idoneità per principianti
72/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
node.js, typescript
Ambito
backend, security

Direzione di ricerca

Start at server/admin/src/server/middleware/auth.ts: read the key derivation (SECRET || "tailchat" plus md5 of adminAuth) and the JWT verify/platform check at lines 37-55, and compare with the login guard in server/admin/src/server/router/api.ts lines 31-35. The fix is to reject protected requests when ADMIN_PASS/SECRET are empty or default, and mirror it in server/admin-next/src/server/middleware/auth.ts (platform 'admin-next'). Done when the issue's proof-of-concept fetch to an admin endpoint returns 401 under the shipped docker-compose.env defaults, while a login with configured credentials still works.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Empty Admin Credentials Still Allow Forged Admin JWTs

Hello Tailchat maintainers, could you review a conditional authentication bypass in the optional admin service?

Summary

With the repository's docker-compose.env defaults, SECRET and ADMIN_PASS are empty and ADMIN_USER is tailchat. The admin signing key is therefore the publicly derivable value tailchat545497b05dba745043d8f287871bfa91. The login route rejects requests because the password is empty, but protected admin routes still accept a JWT signed with this key and containing platform: "admin".

Details

Reviewed revision: 89ab8bba033603415f46fc228b5771d99daa6a21.

Image

auth.ts derives the signing key from SECRET || "tailchat" plus md5(JSON.stringify(adminAuth)). The shipped docker-compose.env sets SECRET=, ADMIN_USER=tailchat, and ADMIN_PASS=. These values produce the key above.

Image

The inline comment says this MD5-derived suffix is intended to prevent token forgery when SECRET is unset and the admin credentials are changed. That protection relies on at least one credential being private. With the shipped defaults, both inputs are public; MD5 deterministically produces a public suffix and adds no secret entropy. This finding does not claim that every deployment with an unset SECRET is affected: deployments using non-public admin credentials derive a different key.

The login route refuses authentication when the admin password is empty (api.ts). However, the middleware only verifies the JWT and checks payload.platform === "admin"; it does not reject requests when admin credentials are unset (auth.ts). Protected endpoints include /callAction and user-management routes (api.ts). The admin service is optional and is exposed through the repository's docker/admin.yml.

The parallel admin-next middleware uses the same key derivation and accepts platform: "admin-next" (admin-next/auth.ts).

The admin service is optional and is not part of the base docker-compose.yml. Its deployment guide tells operators to set an independent ADMIN_PASS. Tailchat also documents that the default SECRET is public and must be replaced in production (environment documentation). Therefore, this finding applies when an operator enables the optional admin service but leaves both the shipped admin credentials and public fallback SECRET unchanged. The admin process does start in this configuration: startup validates MONGO_URL, not ADMIN_USER or ADMIN_PASS (index.ts). The login route is disabled, but protected API middleware still accepts the publicly forgeable admin JWT.

Proof of concept

For a deployment that enables the optional admin service and leaves the tracked docker-compose.env values unchanged, sign and send a token to a protected admin endpoint:

import jwt from 'jsonwebtoken';
import md5 from 'md5';

const authSecret =
  'tailchat' +
  md5(JSON.stringify({ username: 'tailchat', password: '' }));

const token = jwt.sign({ platform: 'admin' }, authSecret);
const response = await fetch(
  'http://localhost:11000/admin/api/user/count/summary',
  { headers: { authorization: `Bearer ${token}` } },
);
console.log(response.status, await response.text());

The request is authorized without using the admin login route or knowing an admin password.

Impact

An unauthenticated network attacker who can reach an enabled admin service under these unchanged values can impersonate an administrator and access or modify data through protected admin APIs. This is a conditional default-key issue (CWE-1394: Use of Default Cryptographic Key). It requires enabling the optional admin service while ignoring the documented requirements to set an independent admin password and replace the public production SECRET; deployments following those instructions are not affected by this specific path.

Related Works

This report is part of my ongoing security research. If you have any questions, please feel free to mention me. I would be glad to make even a small contribution to improving Tailchat's security.

Lingua principale
TypeScript
Stelle
3.6k
Fork
397
Merge medio
2m
PR unite (30g)
1

Preparare l'ambiente

  • Include un Dockerfile o un file Docker Compose
  • Nessun modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di msgbyte/tailchat

Tutte le issue di msgbyte/tailchat

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.