win32/smtc: add an option to skip fetching file thumbnails (GetThumbnailAsync)

Aperta
#18,756 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
55/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
c
Ambito
desktop

Direzione di ricerca

Read osdep/win32/smtc.cpp, especially update_thumbnail() around lines 187–260, to trace when GetThumbnailAsync runs and how existing media controls options are handled. Check the related option and property definitions and their tests or documentation before estimating the change. Done means the option prevents shell thumbnail fetching while the rest of SMTC controls continue working; the issue does not name a test or specify runtime property behavior.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

meta:feature-request
Expected behavior of the wanted feature

Add an option that prevents SMTC from fetching a thumbnail from the Windows shell when the
currently playing file has no embedded cover art.

What happens today: on Windows, update_thumbnail() in osdep/win32/smtc.cpp (~lines 187-260)
calls StorageFile::GetThumbnailAsync(ThumbnailMode::SingleItem, 240) whenever metadata is
published and the file has no embedded cover. That call makes the Windows shell generate a
thumbnail for the file, which is real work inside explorer.exe.

Measured on Windows 10 21H2 (19044), mpv 0.41.0-920 (shinchiro 2026-08-08), plain MP3 without
an APIC frame, one fresh mpv process per playback:

  • explorer.exe GUI objects: +9 to +37 (GDI), +4 to +31 (USER), 0.60-0.66 s after the process
    starts, then back to baseline; the desktop icons visibly repaint.
  • Same audio but with an embedded cover (ID3v2.3 APIC injected into the file, audio untouched):
    0 objects, 0 repaints, 5 out of 5 runs.
    The attached log shows "Generating thumbnail for: ..." three times within 35 ms.

Why it matters: front-ends that spawn one mpv process per track (cue/layer players, radio
automation) trigger that shell work on every playback, and on Windows the desktop repaint is
visible to the operator. The only workaround today is --media-controls=no, which disables SMTC
completely and introduces an unrelated side effect: with SMTC off, the Windows shell keeps the
"busy" cursor for about 5 s for every new audio session (also measured, reproducible with plain
mpv.exe against a non-default endpoint, so that part is shell behaviour, not mpv's).

Proposal: add an option, e.g. --media-controls-thumbnail=no (or a sub-option of
--media-controls), that skips the GetThumbnailAsync call while keeping the rest of SMTC
(title/artist/transport controls) working.

Alternative behavior of the wanted feature

If adding an option is not wanted, simply do not request a thumbnail when the file has no
embedded cover art: the shell then generates a generic thumbnail of the file, which in the SMTC
media card is barely distinguishable from the default application icon (purely cosmetic loss).

Bonus: expose it as a runtime property (like the existing --media-controls toggle) so a
front-end can turn it on/off without restarting mpv.

Log File

Attached: mpv-smtc-thumbnail.log

Generated with:
mpv.exe --no-video --volume=0 --length=3
--msg-level=all=no,SystemMediaTransportControls=trace,cplayer=info
--log-file=mpv-smtc-thumbnail.log "file-without-cover.mp3"

Relevant lines:
[0.022][t][SystemMediaTransportControls] Generating thumbnail for:
[0.051][t][SystemMediaTransportControls] Generating thumbnail for:
[0.057][t][SystemMediaTransportControls] Generating thumbnail for:

Sample Files

mpv-smtc-thumbnail.log

Lingua principale
C
Stelle
38.2k
Fork
3.7k
Merge medio
1g 13h
PR unite (30g)
76

Preparare l'ambiente

  • Nessun Dockerfile né file Docker Compose
  • Ha un modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di mpv-player/mpv

Tutte le issue di mpv-player/mpv

Issue simili

Altre issue su C

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.