Built-in server-side support for incremental scope consent (SEP-835)
Nessuno ha ancora preso questa issue.
- #1483 di @copilot-swe-agent — chiusa senza merge
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 38/100
- Tipo di issue
- Funzionalità
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Ferma
- Stack tecnologico
- csharp
- Ambito
- api, authorization, backend
Direzione di ricerca
Inizia con src/ModelContextProtocol.AspNetCore/AuthorizationFilterSetup.cs e StreamableHttpHandler.cs, quindi esamina i test proposti in tests/ModelContextProtocol.AspNetCore.Tests/IncrementalConsentTests.cs. Il lavoro è completato quando i primitivi autorizzati rimangono visibili senza AddAuthorizationFilters, le invocazioni non autorizzate restituiscono HTTP 403 con gli header WWW-Authenticate specificati, le chiamate autorizzate hanno esito positivo e il comportamento esistente dei filtri rimane invariato.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary
Add built-in server-side support for incremental scope consent (SEP-835) so that MCP servers can use [Authorize] on tools, prompts, and resources without calling AddAuthorizationFilters(), and the SDK automatically returns HTTP 403 with proper WWW-Authenticate headers to trigger client re-authentication.
The SDK already has full client-side support via ClientOAuthProvider, which handles 403 insufficient_scope challenges. This issue covers the missing server-side half.
Motivation
Currently, servers that want per-primitive authorization must call AddAuthorizationFilters(), which:
- Hides
[Authorize]-decorated primitives from list results - Returns JSON-RPC errors (within HTTP 200) for unauthorized invocations
Neither behavior works for incremental scope consent, which requires:
- Primitives to be visible in listings so clients can discover them
- Unauthorized invocations to return HTTP 403 with
WWW-Authenticate: Bearer error="insufficient_scope", scope="...", resource_metadata="..."so the client can re-authenticate with broader scopes
Proposed Design
Usage Pattern
// Server setup — note: NO call to AddAuthorizationFilters()
builder.Services.AddMcpServer()
.WithHttpTransport()
.WithTools<MyTools>();
// Tool with scope requirement
[McpServerToolType]
public class MyTools
{
[McpServerTool, Description("Reads a file")]
[Authorize(Roles = "read_files")]
public static async Task<string> ReadFile(string path, CancellationToken ct)
{
// ...
}
}
How It Works
- Server decorates primitives with
[Authorize(Roles = "scope_name")]but does NOT callAddAuthorizationFilters() AddAuthorizationFilters()is unchanged — servers that use it get the existing hide/block behavior- Primitives with
[Authorize]are visible in listings (since the listing filter is not registered) - On invocation (
tools/call,prompts/get,resources/read), a new pre-flight check inStreamableHttpHandlerevaluates authorization before SSE streaming begins - If unauthorized → HTTP 403 with
WWW-Authenticate: Bearer error="insufficient_scope", scope="scope_name", resource_metadata="..." - The client's
ClientOAuthProviderhandles the 403 → re-auth with new scope → retry
Why Pre-flight?
The auth check must happen before InitializeSseResponse because SSE response headers are committed (HTTP 200) before the MCP filter pipeline runs. Once headers are committed, the status code cannot be changed to 403.
HandlePostRequestAsync (current):
InitializeSseResponse(context) // Sets Content-Type: text/event-stream
└─ session.Transport.HandlePostRequestAsync
└─ responseStream.FlushAsync() // ← COMMITS HEADERS AS 200
MessageWriter.WriteAsync(message) // Queues for session processing
// Auth filter runs here — too late for HTTP 403
The pre-flight check inserts before InitializeSseResponse:
HandlePostRequestAsync (proposed):
parse message, get session
TryHandleInsufficientScopeAsync(...) // NEW — can still write HTTP 403
InitializeSseResponse(context) // Only reached if auth passed
session.Transport.HandlePostRequestAsync(...)
Implementation Plan
1. Relax Check filters in AuthorizationFilterSetup
The PostConfigure method registers "Check" filters that throw InvalidOperationException if auth metadata exists but AddAuthorizationFilters() wasn't called. These must be updated to allow the incremental consent path (HTTP transport handles auth at the HTTP level instead).
File: src/ModelContextProtocol.AspNetCore/AuthorizationFilterSetup.cs
2. Pre-flight authorization in StreamableHttpHandler
Add TryHandleInsufficientScopeAsync in HandlePostRequestAsync:
- Skip if
AddAuthorizationFilterswas called (let it handle auth its way) - For
tools/call,prompts/get,resources/readrequests: parse target name, look up primitive - Check
IAuthorizeDatametadata, evaluateIAuthorizationService - If unauthorized: extract scope from
IAuthorizeData.Roles, write HTTP 403 withWWW-Authenticateheader and JSON-RPC error body
File: src/ModelContextProtocol.AspNetCore/StreamableHttpHandler.cs
3. Tests
[Authorize]primitives visible in listings withoutAddAuthorizationFilters- Invocation returns HTTP 403 with proper
WWW-Authenticateheaders - Authenticated user with sufficient claims can invoke successfully
AddAuthorizationFiltersbehavior is unchanged
File: tests/ModelContextProtocol.AspNetCore.Tests/IncrementalConsentTests.cs (new)
4. Documentation
- XML doc comments on new/modified APIs
- Usage guide documenting the
[Authorize(Roles = "scope")]pattern
Key Advantages
- No new types or attributes — reuses standard
[Authorize(Roles = "...")] - No breaking changes —
AddAuthorizationFiltersis untouched - Clean separation —
AddAuthorizationFilters= hide/block model; omitting it = incremental consent model WithHttpTransport()auto-registers — no extra API calls needed- Works with existing client —
ClientOAuthProvideralready handles 403insufficient_scope
Related
- SEP-835: https://github.com/modelcontextprotocol/modelcontextprotocol/pull/835
- Original issue: #907 (closed — covered client-side; this covers server-side)
- Client-side implementation:
ClientOAuthProvider.ShouldRetryWithNewAccessTokenhandles 403insufficient_scope
- Lingua principale
- C#
- Stelle
- 4.5k
- Fork
- 814
- Merge medio
- 9g 19h
- PR unite (30g)
- 4
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di modelcontextprotocol/csharp-sdk
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
modelcontextprotocol/csharp-sdk#1867 ·
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
modelcontextprotocol/csharp-sdk#1840 · 1 commento ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
modelcontextprotocol/csharp-sdk#1836 ·
-
enhancement needs confirmation
Difficoltà 2/5 1-3 ore Idoneità per principianti 64/100
modelcontextprotocol/csharp-sdk#678 · 1 commento ·
-
enhancement needs confirmation P3 ready for work
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
modelcontextprotocol/csharp-sdk#515 · 6 commenti · 3 reazioni ·
Tutte le issue di modelcontextprotocol/csharp-sdk
Issue simili
-
untriaged
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
dotnet/dotnet-api-docs#13095 ·
-
area-deployment area-integrations triage:bot-seen
Difficoltà 2/5 Mezza giornata Idoneità per principianti 86/100
-
type/automation type/tech-debt
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
-
bug
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 90/100
newrelic/newrelic-dotnet-agent#3850 · 1 commento ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
LuckyPennySoftware/AutoMapper#4660 ·