Dafny: `<T extends B>` is replaced by `B`, so a call with any other record type is ill-typed (and an inline `B` is emitted as TypeScript text)

Aperta
#305 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
backend, compilers

Direzione di ricerca

Start in tools/src/extract.ts, in extractFunctionInner around line 2122, and trace how bounded type parameters are added to _typeParamMap; compare the inline object bound path with the synthetic naming described in issue #276. Reproduce both examples with Dafny 4.11 and inspect the generated Dafny and its type errors. Done means wider record arguments retain the generic return type, inline bounds no longer emit TypeScript syntax, or unsupported cases receive a clear diagnostic.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Version: lsc 0.6.10 (npm), Dafny 4.11. Still present on main at 93283ec, tools/src/extract.ts, extractFunctionInner (around line 2122).

When a bound is a record, extractFunctionInner substitutes T with the bound's text (_typeParamMap.set(tp.getName(), constraint.getText())). This lets field reads through T typecheck. But it loses the reason for writing a bounded generic, which is that callers pass a type wider than the bound. It breaks in two ways.

1. A caller with a wider record doesn't resolve.

//@ backend dafny
export interface HasParams { readonly params: readonly string[] }
export interface Fn { readonly name: string; readonly params: readonly string[] }

export function firstOrSelf<T extends HasParams>(fn: T): T {
  //@ verify
  return fn
}
export function paramCount<T extends HasParams>(fn: T): number {
  //@ verify
  return fn.params.length
}
export function useIt(f: Fn): number {
  //@ verify
  //@ ensures \result === f.params.length
  return paramCount(f)
}
datatype HasParams = HasParams(params: seq<string>)
datatype Fn = Fn(name: string, params: seq<string>)

function firstOrSelf(fn: HasParams): HasParams { fn }
function paramCount(fn: HasParams): int { |fn.params| }
function useIt(f: Fn): int { paramCount(f) }
i4b.dfy(19,13): Error: incorrect argument type for function parameter 'fn' (expected HasParams, found Fn)

firstOrSelf also returns HasParams. A caller can't get its Fn back, which a T-returning signature promises.

2. An inline object bound is emitted as TypeScript text.

//@ backend dafny
export function paramCount<T extends { params: string[] }>(fn: T): number {
  //@ verify
  //@ ensures \result === fn.params.length
  return fn.params.length
}
type { params: string[] }(==)

function paramCount(fn: { params: string[] }): int
i4.dfy(3,5): Error: invalid Ident

This is the same mechanism as #276 (an inline object type on a parameter), reached through the bound.

In TypeScript, paramCount(f) with f: Fn is fine. T is inferred as Fn, and firstOrSelf(f) has type Fn.

Suggested direction: keep T as a Dafny type parameter. Model the fields the body reads through the bound as accessor functions passed in, or as a trait. Another option is to monomorphise per call-site type: emit paramCount_Fn(fn: Fn) for each record type paramCount is called with. Either way, substituting the bound only works when every caller passes exactly the bound type, so lsc could at least reject a call whose argument type differs from it, with a clear message instead of a Dafny type error. An inline bound needs the synthetic naming that interface fields get (see #276).

Workaround: drop the generic and pass what the function reads, e.g. paramCount(params: readonly string[]), called as paramCount(f.params).

Lingua principale
TypeScript
Stelle
113
Fork
13
Merge medio
16h 8m
PR unite (30g)
42

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di midspiral/LemmaScript

Tutte le issue di midspiral/LemmaScript

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.