lsc check accepts added requires/ensures lines in .dfy, so a proof file can make obligations vacuous

Aperta
#301 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
25/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
tooling

Direzione di ricerca

Start with additionsOnly in tools/src/dafny-commands.ts, which currently rejects only deleted lines when .dfy is compared with .dfy.gen. Reproduce the two cases from the issue: an added requires in a generated header, and an added assume or {:axiom} declaration, both passing lsc check. Done means these additions are rejected or explicitly configured, while legitimate appended lemmas still pass. The issue leaves the exact rule open, so agree on it with maintainers first.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

This was generated by AI during triage.

Summary

lsc check treats any line that appears in foo.dfy but not in foo.dfy.gen as an allowed proof addition. additionsOnly in tools/src/dafny-commands.ts (checked on main at 566df0d) rejects only deleted lines. An added requires, assume, or {:axiom} passes the check. Each of these weakens what is proved while lsc check still reports success.

Reproduction

Observed with lemmascript 0.6.8 and Dafny 4.11.0. The code involved is unchanged on main.

  1. Write a function with a guard in its contract and run lsc gen, so that counter.dfy and counter.dfy.gen both contain:

    function increment(c: Counter): Counter
      requires inRange(c) && belowMaximum(c)
    
  2. Remove belowMaximum(context) from the TypeScript //@ requires (or from the guard in the body) and run lsc gen again. counter.dfy.gen is regenerated without the clause. counter.dfy is left as it was.

  3. Run lsc check. It reports all obligations verified. The diff from .dfy.gen to .dfy shows the stale requires ... && belowMaximum(c) line as an addition, so the check accepts it and Dafny verifies the old, stronger-precondition model instead of the current source.

The same check accepts lines added inside a generated header. Adding two lines to a generated contract lemma:

lemma increment_ensures(context: Context)
  requires inRange(context)
  requires belowMaximum(context)
  requires false   // added
  ensures false    // added
  ensures inRange(increment(context))

and running lsc check --backend=dafny quantityCounter.ts regenerates .dfy.gen, passes the diff check, and prints Dafny program verifier finished with 11 verified, 0 errors, including the proof of ensures false. It also accepts new declarations that use assume or {:axiom}, which a proof addition can then rely on. Putting {:axiom} on an existing generated line does count as a modification and is rejected.

Expected

Proof additions should not be able to change what the generated declarations claim. Possible rules:

  • Reject added lines that fall inside a generated declaration's header (requires, ensures, decreases, reads, attributes). Allow new declarations and lemma bodies.
  • Reject assume and {:axiom} in proof additions unless explicitly allowed by configuration.
  • Optionally, have lsc check warn when .dfy predates the latest .dfy.gen and the regen merge was not run.

Context

We work around this in a downstream runner by requiring the generated text to appear byte-for-byte in the proof file, allowing only appended declarations and lemma calls, and refusing assume and attributes. We would prefer to rely on lsc check for this. Related, closed: #280 (regen merge conflicts), #192 (a translation that verified the wrong model).

Lingua principale
TypeScript
Stelle
113
Fork
13
Merge medio
16h 22m
PR unite (30g)
40

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di midspiral/LemmaScript

Tutte le issue di midspiral/LemmaScript

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.