openvmm: virtiofs: microVM readdirplus fails with ENOENT when directory entries are unlinked during pagination

Aperta
#1,622 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
62/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
rust

Direzione di ricerca

Start in vm/devices/virtio/virtiofs/src/microvm/file.rs, comparing read_dir_microvm with VirtioFsFile::read_dir_with in vm/devices/virtio/virtiofs/src/file.rs; the latter shows the intended ENOENT/EACCES handling. Follow the plus branch around lookup_helper and the trailing EINVAL check, then reproduce with a two-page directory snapshot whose later entry is unlinked. Done means skipped entries are handled without aborting, buffered lookup references are not leaked, and end-of-directory does not return EINVAL merely because remaining entries were skipped.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area: openvmm

Summary

In microVM mode, VirtioFsFile::read_dir_microvm snapshots a directory's entries once when first read at offset == 0 and then calls fs.lookup_helper(&self.inode, name)? on each cached entry during FUSE_READDIRPLUS, propagating Err(lx::Error::ENOENT) directly to the guest instead of skipping unlinked entries as non-microVM VirtioFsFile::read_dir_with does. Unlinking or renaming an entry in a multi-page directory while paginating it (such as during rm -rf) causes FUSE_READDIRPLUS to fail with ENOENT on that page and on every subsequent read of that open directory handle until closed. Found by testing.

Root Cause

In vm/devices/virtio/virtiofs/src/microvm/file.rs, VirtioFsFile::read_dir_microvm materializes snapshot.entries once per open directory handle on the initial offset == 0 read and reuses that immutable snapshot across all continuation reads. In the plus branch (microvm/file.rs), read_dir_microvm uses ? on fs.lookup_helper(&self.inode, name):

                    // This check must happen before lookup_helper, because a
                    // readdirplus lookup creates a guest lookup reference.
                    if !buffer.check_dir_entry_plus(name) {
                        break;
                    }
                    let fuse_entry = fs.lookup_helper(&self.inode, name)?;
                    if fuse_entry.attr.ino != entry.guest_inode_id {
                        return Err(lx::Error::EIO);
                    }
                    if !buffer.dir_entry_plus(name, entry.next_cookie, fuse_entry) {
                        return Err(lx::Error::EIO);
                    }

By contrast, the non-microVM implementation in VirtioFsFile::read_dir_with explicitly ignores ENOENT and EACCES when an enumerated entry disappears or becomes inaccessible before lookup runs:

                    match lookup(&entry.name) {
                        Ok(e) => e,
                        Err(err) => {
                            // Ignore entries that are inaccessible to the
                            // user or deleted. ENOENT can occur if a file was
                            // deleted between enumeration and lookup.
                            if err.value() == lx::EACCES || err.value() == lx::ENOENT {
                                entry_count -= 1;
                                return Ok(true);
                            }
                            return Err(err);
                        }
                    }

Consequence

Because the microVM profile enables FUSE_DO_READDIRPLUS and FUSE_READDIRPLUS_AUTO, guest directory readers (getdents64) issue paginated FUSE_READDIRPLUS requests (typically 4 KiB per page, holding roughly 25–30 entries). Standard directory-removal and cleanup tools (rm -rf, find -delete, std::fs::remove_dir_all, Go os.RemoveAll, log rotation, and concurrent build/test runners) keep an open directory descriptor while unlinking entries — or encounter entries unlinked or renamed between pages by another guest process or on the host. Once any entry on an unread page of snapshot.entries is unlinked or renamed away, the continuation READDIRPLUS fails with ENOENT, discarding any entries already buffered in that call (and leaking their lookup references unless rolled back). Worse, because the guest's directory offset never advances past the missing entry and snapshot.entries is never rebuilt for that handle, every subsequent READDIRPLUS on that open directory handle fails with ENOENT until closed.

Reproduction

  1. Create a microVM VirtioFs share containing a directory with ~60 files (f00..f59), enough to span at least two 4 KiB FUSE_READDIRPLUS pages.
  2. Open the directory via FUSE_OPENDIR and issue FUSE_READDIRPLUS at offset = 0 with size = 4096, populating directory_snapshot and returning the first page of entries ending at cookie c.
  3. Unlink (via FUSE_UNLINK or on the host) one of the files positioned after cookie c in the snapshot.
  4. Issue FUSE_READDIRPLUS at offset = c with size = 4096. Observe Err(lx::Error::ENOENT) on that call and on every retry at offset = c for the lifetime of the open handle.

Suggested Fix

In VirtioFsFile::read_dir_microvm, align the plus path with VirtioFsFile::read_dir_with by skipping snapshot entries when fs.lookup_helper(&self.inode, name) returns lx::Error::ENOENT or lx::Error::EACCES (continue to the next snapshot entry instead of aborting). For any other lookup_helper error, stop the loop and return already-buffered entries if buffer is non-empty so lookup references acquired earlier in the batch are not leaked. In addition, adjust the trailing if !entries[start..].is_empty() && buffer.is_empty() { return Err(lx::Error::EINVAL); } check so it only returns EINVAL when size was too small to fit a live entry (!buffer.check_dir_entry_plus(name)), rather than returning EINVAL at end-of-directory when every remaining entry in entries[start..] was skipped with ENOENT or EACCES.

Related: #1611, #1605, #1634.

Lingua principale
Rust
Stelle
831
Fork
56
Merge medio
13h 37m
PR unite (30g)
571

Preparare l'ambiente

  • Nessun Dockerfile né file Docker Compose
  • Ha un modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di microsoft/nvx

Tutte le issue di microsoft/nvx

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.