prune_kv_values_updated_before emits actions in HashMap order; replay fails with `kv clear mismatch`
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 25/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Ferma
- Stack tecnologico
- node.js, rust
- Ambito
- distributed-systems
Direzione di ricerca
Start in src/lib.rs at prune_kv_values_updated_before (around lines 3411-3427), then inspect get_kv_all_keys around lines 3360-3362 and the kv_metadata declaration around line 1715. Reproduce the Node.js SDK scenario with multiple matching keys and verify that replay emits and consumes KV actions in a consistent order.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary
An orchestration that prunes two or more KV keys in one turn fails on a later replay with nondeterministic: kv clear mismatch. The orchestration code is deterministic. The order of the actions that the runtime emits is not.
Where
prune_kv_values_updated_beforeiterateskv_metadataand callsclear_kv_valuefor each key: https://github.com/microsoft/duroxide/blob/6a458861763a7aa5b78a7c1c97691a6f00489a8b/src/lib.rs#L3411-L3427kv_metadatais astd::collections::HashMap: https://github.com/microsoft/duroxide/blob/6a458861763a7aa5b78a7c1c97691a6f00489a8b/src/lib.rs#L1715get_kv_all_keysreturns the keys inHashMaporder as well: https://github.com/microsoft/duroxide/blob/6a458861763a7aa5b78a7c1c97691a6f00489a8b/src/lib.rs#L3360-L3362
A HashMap has a random seed per map. So the iteration order differs between two replays of the same turn, also inside one process.
How it fails
- Execution 1 writes the keys
atofand continues as new. - Execution 2 calls
prune_kv_values_updated_before(cutoff). All six keys match. The turn records sixKeyValueClearedevents in some order. - A later turn replays the same code. The six
ClearKeyValueactions come out in a different order. - The replay engine compares the first action with the first event, finds another key, and fails the orchestration.
Reproduction
Reproduced with duroxide 0.1.30 on SQLite, through the Node.js SDK:
runtime.registerOrchestration('Prune', function* (ctx, input) {
if (!input || !input.second) {
for (const k of ['a', 'b', 'c', 'd', 'e', 'f']) ctx.setValue(k, 'x');
yield ctx.continueAsNew({ second: true });
return '';
}
const now = yield ctx.utcNow();
const pruned = ctx.pruneKvValuesUpdatedBefore(now + 60_000); // clears all six keys
yield ctx.utcNow();
yield ctx.utcNow();
return `pruned ${pruned}`;
});
6 of 6 instances failed, for example with:
nondeterministic: kv clear mismatch: action=ClearKeyValue { key: "d" } vs event=KeyValueCleared { key: "a" }
Impact
- An orchestration that calls
prune_kv_values_updated_beforewith more than one matching key can fail for good. With n keys, two replays agree on the order with a chance of 1 in n!. get_kv_all_keysandget_kv_all_valueshand the same random order to orchestration code. Code that loops over the result and schedules work per key is nondeterministic for the same reason.
Suggested fix
- Sort the keys in
prune_kv_values_updated_beforebefore the actions are emitted. - Return sorted keys from
get_kv_all_keys, or keep the KV state in aBTreeMap.
Tracked in #55.
- Lingua principale
- Rust
- Stelle
- 221
- Fork
- 61
- Merge medio
- 3g 5h
- PR unite (30g)
- 1
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di microsoft/duroxide
-
One failed session lock renewal loses the session: no retry, no log, no signal to running activitiesApertabug
Difficoltà 4/5 3-5 giorni Idoneità per principianti 30/100
-
bug
Difficoltà 3/5 1-2 giorni Idoneità per principianti 72/100
-
bug
Difficoltà 5/5 Più di una settimana Idoneità per principianti 38/100
-
bug
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
-
bug
Difficoltà 4/5 3-5 giorni Idoneità per principianti 35/100
Tutte le issue di microsoft/duroxide
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
pact-foundation/pact-cli#154 ·
I maintainer di solito rispondono entro 3 giorni
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
antithesishq/bombadil#361 ·
I maintainer di solito rispondono entro 1 giorno
-
test(executor_l0): assert execute() TaskOutcome, not only bus events / 断言 execute() 返回的 TaskOutcomeApertatype:debt
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
skaiy/wild_agentos#425 ·
I maintainer di solito rispondono entro 1 giorno
-
Default-import note suggests `import * as process` for velt:process, which does not name the builtinAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno
-
bug ticket
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
cratestack/cratestack#1154 ·
I maintainer di solito rispondono entro 1 giorno