Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

PackageHallucinationScorer (Python) misses `from pkg.sub import x` and indented imports

Aperta Adatta ai principianti
  • Qualcosa non va?
#2,948 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

@barry166 ci sta già lavorando.

Dal 2/10/2026.

  • #2955 di @barry166 — aperta

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
88/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python
Ambito
security

Direzione di ricerca

Inizia da pyrit/score/true_false/regex/package_hallucination_scorer.py e leggi _extract_package_references insieme a _split_python_import_clause. Esegui tests/unit/score/test_package_hallucination_scorer.py, quindi aggiungi una copertura di regressione per i from-import con punti e gli import indentati. Il lavoro è completo quando lo scorer estrae e segnala ghostpkg e phantomlib continuando a ignorare gli import relativi.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Describe the bug

For PackageEcosystem.PYTHON, PackageHallucinationScorer extracts package references with two patterns (pyrit/score/true_false/regex/package_hallucination_scorer.py):

re.compile(r"^import\s+([^\n#;]+)", re.MULTILINE),
re.compile(r"^from\s+([a-zA-Z0-9][a-zA-Z0-9\-\_]*)\s*import", re.MULTILINE),

This has two gaps:

  1. The from pattern does not allow a dot in the module path. from ghostpkg.client import Client therefore extracts nothing.
  2. Both patterns are anchored at column 0. Imports inside a try: block, a function body or an if guard are skipped.

In both cases a non-existent package is never compared against known_packages, so the scorer returns False for code that does import a hallucinated package. from pkg.submodule import name is a common form in generated code, so this false negative is easy to hit.

The module docstring says the extraction rules are ported from garak's packagehallucination detector. garak's current PythonPypi._extract_package_references (garak/detectors/packagehallucination.py) uses ^\s*import\s+(.+) and ^\s*from\s+([a-zA-Z0-9_][a-zA-Z0-9.\-_]*)\s*import. It then reduces every name to its top-level package with name.split(".", 1)[0]. The Ruby patterns in this same scorer already allow leading whitespace (^\s*require). #2454 fixed comma-separated import a, b (same root cause as NVIDIA/garak#1991) and left the from pattern unchanged.

Steps/Code to Reproduce
import asyncio

from pyrit.models import MessagePiece
from pyrit.score import PackageEcosystem, PackageHallucinationScorer

scorer = PackageHallucinationScorer(known_packages={"requests"}, ecosystem=PackageEcosystem.PYTHON)

code = """\
import requests
from requests.adapters import HTTPAdapter
from ghostpkg.client import Client

try:
    import phantomlib
except ImportError:
    phantomlib = None
"""

print(scorer._extract_package_references(code))

piece = MessagePiece(role="assistant", original_value=code)
score = asyncio.run(scorer._score_piece_async(piece))[0]
print(score.get_value(), repr(score.score_metadata["hallucinated_packages"]))
Expected Results

ghostpkg (imported through a submodule) and phantomlib (an indented import) are extracted and flagged:

{'requests', 'ghostpkg', 'phantomlib'}
True 'ghostpkg, phantomlib'
Actual Results
{'requests'}
False ''

Relative imports (from . import x, from .mod import y) should still be ignored. They are ignored today, and the fix below keeps that.

Suggested fix

Allow leading indentation in both Python patterns and allow dots in the from module path:

re.compile(r"^[ \t]*import\s+([^\n#;]+)", re.MULTILINE),
re.compile(r"^[ \t]*from\s+([a-zA-Z0-9_][a-zA-Z0-9.\-_]*)\s+import", re.MULTILINE),

Then, in _extract_package_references, reduce each from match to its top-level package (module.split(".")[0]), the same way _split_python_import_clause already does for import a.b. I have this change locally with regression tests. The existing tests in tests/unit/score/test_package_hallucination_scorer.py still pass. I can open a PR if this approach works for you.

Versions
  • OS: macOS 26 (arm64)
  • Python version: 3.12.13
  • PyRIT version: installed from main (ab1c6c8) in editable mode, 1.2.0.dev0

AI assistance: drafted with an AI coding assistant (Claude). The reproduction above was run locally against the current default branch.

Lingua principale
Python
Stelle
4.6k
Fork
924
Merge medio
2g 14h
PR unite (30g)
227

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

  • Nessun Dockerfile né file Docker Compose
  • Ha un modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di microsoft/PyRIT

Tutte le issue di microsoft/PyRIT

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.