Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

MAINT Extract attack factory constructor compatibility rules

Aperta
#2,764 2 commenti 0 reazioni 1 assegnatario Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
58/100
Tipo di issue
Refactoring
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python
Ambito
ai, security, tooling

Direzione di ricerca

Start with pyrit/scenario/core/attack_technique_factory.py and tests/unit/scenario/core/test_attack_technique_factory.py, following doc/code/framework.md and the scenario, Python, and test instructions. Trace the listed constructor-inspection and scoring-compatibility methods through real factory creation. Done means the helper preserves existing type-hint, optional, policy, converter-check, signature, identifier, and factory behavior, with focused coverage.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

help wanted
Is your feature request related to a problem? Please describe.

AttackTechniqueFactory mixes constructor inspection and scoring-configuration compatibility with assembling attack instances. _get_accepted_params, _get_scoring_config_type, _unwrap_optional, _should_apply_scoring_config, and _apply_scorer_policy form a small compatibility subsystem that is harder to understand while mixed into the rest of the factory.

This is F1 of three small factory extractions. It is ready for implementation and does not depend on the adversarial-configuration or converter-composition extractions.

Describe the solution you'd like

Extract the existing constructor-contract inspection and compatibility decisions into a small private, typed helper in the scenario core package. Keep AttackTechniqueFactory as the public entry point and wire the helper into its existing validation and creation paths.

  • Represent accepted constructor parameters and the existing scoring-config type contract explicitly rather than repeatedly mixing reflection with configuration assembly.
  • Preserve existing type-hint resolution and optional-type handling. Do not broaden supported annotation shapes or introduce a new compatibility policy in this refactor.
  • Preserve ScorerOverridePolicy raise/warn/skip behavior, including when a supplied scoring configuration is omitted from constructor arguments.
  • Keep configuration compatibility at the technique/factory layer. Do not move it into scorers, targets, or attack algorithms.

Acceptance criteria:

  • Factories accept and reject the same constructor/configuration combinations as before.
  • Constructor parameter discovery, supported optional annotations, annotation-resolution fallback, and narrowed scoring-config types preserve their existing behavior.
  • Missing or incompatible scoring parameters exercise each existing policy with unchanged exceptions/warnings and effective constructor arguments.
  • Existing converter-capability checks that depend on constructor parameters still behave identically.
  • Public signatures, registered technique behavior, and component identifiers remain unchanged.
  • Focused factory coverage exercises the helper through real factory creation as well as its compatibility decisions.
Describe alternatives you've considered, if relevant

Do not introduce a generic dependency-injection/reflection framework or a new public factory API. Avoid splitting each reflection call into a pass-through wrapper. One cohesive contract helper is enough; additional caching is not required.

Additional context

Starting points: pyrit/scenario/core/attack_technique_factory.py and tests/unit/scenario/core/test_attack_technique_factory.py. Follow doc/code/framework.md and the scenario, Python, and test instructions.

This only concerns factory configuration compatibility. It does not refactor scorer execution, observation acquisition/replay, or the generic scorer lifecycle in #2413. The observation-aware LLM scoring proposal is explicitly deferred until reassessment September 29 through October 6, 2026.

#2494 is changing adversarial prompt assembly in the same factory. Keep this extraction confined to constructor compatibility and preserve that work when integrating; do not bundle its prompt changes.

Lingua principale
Python
Stelle
4.5k
Fork
896
Merge medio
3g 8h
PR unite (30g)
191

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di microsoft/PyRIT

Tutte le issue di microsoft/PyRIT

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.