e2e tests never run on PRs from forks: the Quay login step fails without secrets
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 64/100
Direzione di ricerca
Start with the build-verify.yml package step around lines 52–53, then inspect tests/kuttl-test.yaml and tests/manifests/install-operator.yml to see how the test image is built, loaded and pulled. Check whether the pushed e2e image is used elsewhere, then adjust the CI and image pull behavior so fork PRs test their own image. Done when the kuttl e2e tests run successfully on fork and Dependabot PRs.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Describe the bug
On pull requests from forks, the build-verify-package workflow fails at the step "Package container image for operator e2e tests". This step builds the operator image, then logs in to Quay and pushes it as quay.io/microcks/microcks-operator:e2e-tests (build-verify.yml L52-53). GitHub does not pass repository secrets to PRs from forks, so the Quay username is empty and docker login fails. Because of this, the kuttl e2e tests never run on PRs from forks. Dependabot PRs fail at the same step.
Expected behavior
The e2e tests run on every PR, including PRs from forks.
Actual behavior
The step fails with Error: Cannot perform an interactive login from a non TTY device, and the e2e steps are skipped. The build and unit tests before it pass. For example #306 and #331.
How to Reproduce?
Open any PR from a fork and look at the build-verify-package run.
Microcks version or git rev
main @ 4d74e9f
Install method (docker-compose, helm chart, operator, docker-desktop extension,...)
operator (CI)
Additional information
The push may not be needed. kuttl already loads the image into the kind cluster (kindContainers in tests/kuttl-test.yaml), but tests/manifests/install-operator.yml sets imagePullPolicy: Always, so the pod pulls the image from Quay instead of using the loaded one. A possible fix is to remove the login and push and set imagePullPolicy: IfNotPresent. Only removing the push would not be enough: with Always, fork PRs would test the last image pushed to Quay instead of their own code.
Is the pushed e2e-tests image used for anything else? If not, I'm happy to send a PR.
I used AI tools while working on this and verified everything myself.
- Lingua principale
- Java
- Stelle
- 14
- Fork
- 13
- Merge medio
- 23m
- PR unite (30g)
- 3
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di microcks/microcks-operator
-
{#if spec.commonExpositions.type == "INGRESS"} never matches, so the gRPC TLS properties are never renderedForse già presa @Abhayanthk l’ha presa 10 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 58/100
microcks/microcks-operator#330 ·
Tutte le issue di microcks/microcks-operator
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 66/100
a2aproject/a2a-java#1275 ·
I maintainer di solito rispondono entro 1 giorno
-
module/ftp Type/Bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
ballerina-platform/ballerina-library#9476 ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
anwilli5/coin-collection-android-US#515 ·
I maintainer di solito rispondono entro 1 giorno
-
status: waiting-for-triage type: bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
spring-projects/spring-integration#11654 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 Meno di un'ora Idoneità per principianti 70/100
Vakore/ZappierGames#248 ·