Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

feat(source-control): enforce the four operator values the promotion-evidence helper takes on trust

Chiusa
  • Qualcosa non va?
#7,008 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
22/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
javascript
Ambito
security

Direzione di ricerca

Start with the helper at plugins/source-control/skills/babysit-loop/scripts/resolve-promotion-evidence.mjs, which currently takes the four values as arguments, and with the channel F rules in docs/conventions/hook-config-delivery. The helper should read the operator's own settings itself and ignore the CLAUDE_PLUGIN_OPTION_* mirror and .claude/source-control.md for these values. Done means a test where a stub checker or forged binding in a scratch directory no longer yields promoted, and the bootstrap contract's Out of scope entry is removed.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area: security needs-triage priority: medium

Why

#5677 made the babysit-loop cycle resolve promotion evidence through four bootstrap options: promotion_evidence_checker plus the binding, probe evidence root and evidence options. Its security review lists one gap as "Instructed, not enforced": the four values must come from the operator's substituted user options in the SKILL.md block, never the CLAUDE_PLUGIN_OPTION_* mirror or .claude/source-control.md. The helper receives them as arguments and cannot tell an operator's value from a path the lane chose, so a stub checker or forged binding kept in a scratch directory outside the checkout and worktrees would pass it. Until this is enforced, operators keep --merge human-only.

The 2,000-PRs talk Brief (Q9) asked for this gap to be filed. Two Brief decisions depend on it: Q99 (C2 self-merge stays off) and Q128 (merge authority for autonomous lanes, deferred to #6202).

What

Enforce the four values in code: the helper (plugins/source-control/skills/babysit-loop/scripts/resolve-promotion-evidence.mjs) reads the operator's own settings itself, through channel F of docs/conventions/hook-config-delivery, instead of trusting values passed as arguments. Cover all four surfaces, not only the checker.

Deferred plan text

From the integration branch's local plan (WS-P.md Phase 9), which is not in the repository:

gh issue create --type Task with the scope: enforce the four values #5677 lists as "Instructed, not enforced" (the helper reads the operator's own settings, channel F of docs/conventions/hook-config-delivery); Q99 and Q128 depend on it.

Acceptance

  • The helper resolves all four values (checker, binding, probe evidence root, evidence) from the operator's own settings through channel F, and ignores the CLAUDE_PLUGIN_OPTION_* mirror and .claude/source-control.md for them.
  • A test shows a lane-chosen path outside the checkout (stub checker or forged binding) no longer yields promoted.
  • The bootstrap contract's Out of scope entry for this gap is removed, and the "Instructed, not enforced" item no longer applies.
  • Q99 and Q128 owners (#6202) are told the gap is closed.

Refs: #6085
Refs: #5677
Refs: #4588

Lingua principale
Shell
Stelle
22
Fork
2
Merge medio
7h 8m
PR unite (30g)
874

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di melodic-software/claude-code-plugins

Tutte le issue di melodic-software/claude-code-plugins

Issue simili

Altre issue su Shell/Bash

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.