Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

fix(guardrails): block-root-delete-target skips a PowerShell target holding a literal dollar sign

Chiusa
  • Qualcosa non va?
#6,626 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Una pull request collegata è già stata integrata.

  • #7071 di @kyle-sexton — integrata

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
powershell, shell
Ambito
cli, security

Direzione di ricerca

Start by tracing the block-root-delete-target hook and its rdt_place_to operand handling for PowerShell single-quoted words; inspect the related work in #6020 and #6542. Reproduce the reported cases, including the cmd /c rd invocation from Bash, and determine whether that lane is wired or a declared gap. Done means literal $ operands and ::$ stream suffixes are judged safely, and the cmd case is judged or documented as a gap.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

needs-human needs-triage

Problem

block-root-delete-target leaves a PowerShell target alone when it holds a $, even inside single quotes, where PowerShell expands nothing. rdt_place_to returns "leave alone" for any $ in an operand that is not literal, and a PowerShell single-quoted word goes down that path.

On Win32, <dir>::$INDEX_ALLOCATION names the directory itself, so a spelling like the one below may reach a directory the guard would otherwise refuse.

Repro (hook side confirmed; PowerShell runtime side not verified)

With the key unset and cwd /:

  • Remove-Item -Recurse -Force 'D:\some\outside\dir' exits 2 (refused).
  • Remove-Item -Recurse -Force 'D:\some\outside\dir::$INDEX_ALLOCATION' exits 0 (allowed).

Also seen in the same review: cmd /c rd /s /q <dir> issued from the Bash tool exits 0 even for a directory outside the allowed roots. Check whether this is a declared gap or a lane that is simply not wired.

Acceptance

  • A single-quoted PowerShell operand is judged literally: a $ in it does not skip judgment.
  • A ::$INDEX_ALLOCATION (or other ::$ stream) suffix is judged as the directory before it, or refused.
  • The cmd /c rd from Bash case is either judged or listed as a declared gap.

Related: #6020. Found by the security review of #6542.

Lingua principale
Shell
Stelle
22
Fork
2
Merge medio
8h 25m
PR unite (30g)
944

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di melodic-software/claude-code-plugins

Tutte le issue di melodic-software/claude-code-plugins

Issue simili

Altre issue su Shell/Bash

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.