[2.0] Give repeated inline logotypes unique SVG IDs

Chiusa
  • Qualcosa non va?
#479 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
56/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
html
Ambito
frontend

Direzione di ricerca

Start with site/components/CSSLogotype.svelte around lines 26-32, where the raw SVG artwork is inserted, and check how the file-level SVGO prefix is applied to the light and dark assets. Then run site/tests/docs-quality.e2e.mjs against a local build of site/out to see the no new or changed duplicate document IDs failure. Done means each rendered logotype instance has unique IDs and local references, and that assertion passes in both themes at 390, 768 and 1280 px without a baseline.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Parent: #473

Reproduction

Build the candidate site, serve site/out, and run MASTER_SITE_URL=<local-preview> node site/tests/docs-quality.e2e.mjs with no duplicate-ID baseline. Current documentation pages fail no new or changed duplicate document IDs in light and dark themes at 390, 768 and 1280 px.

A static scan finds duplicate IDs in 151 of 155 built pages. Typical document routes repeat eight master-css-horizontal-on-{light,dark}_svg__{a,b,c,d} IDs twice. The homepage additionally repeats some integration artwork IDs.

Source evidence

site/components/CSSLogotype.svelte:26-32 inserts raw SVG artwork without an instance-specific prefix. The file-level SVGO prefix separates light and dark assets, but does not separate multiple instances of the same asset. Shared header and footer both render the product logotype.

Acceptance

  • Make each inline SVG instance's IDs and local references unique, or use an external-image representation where appropriate.
  • Inspect other repeated homepage artwork.
  • Run the documentation browser audit without a duplicate-ID baseline and verify both color modes.

This is a document-integrity and validation defect. Visible gradient corruption has not been established. Temporary audit-only exact baselines may allow later visual assertions to run, but do not resolve this finding.

Evidence: local candidate 9567e1158f995272c45d341e0eeb3a02a49a8dd0 with pre-existing working-tree changes, 2026-11-04.

Completed full browser run

All 148 documentation routes were tested at 390/768/1280 px in both themes: 888/888 profiles fail at the duplicate-ID assertion. Assertions preceding it (response, geometry, broken article images, browser errors) did not fail. With an exact per-route baseline retained separately, six representative routes pass all 36 profiles including later illustration checks. The unmodified gate remains failing.

Lingua principale
TypeScript
Stelle
2k
Fork
44
Merge medio
1g 14h
PR unite (30g)
1

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di master-co/css

Tutte le issue di master-co/css

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.