Worklets without captured variables are rejected as "Regular javascript function" when transpiled by react-native-worklets' Babel plugin
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 55/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- cpp, javascript, react-native
Direzione di ricerca
Start with cpp/WKTJsiWorklet.h, especially isDecoratedAsWorklet() and createWorklet(), then trace how JsiObjectWrapper::setFunctionValue() handles a function without __closure. Reproduce with the supplied Babel output: a numeric __workletHash, string __initData.code, and no closure. Done when that no-capture worklet is recognized and invoked successfully while existing captured worklets still work.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Description
When a project uses the Babel plugin from react-native-worklets (the Reanimated 4 worklets package) together with react-native-worklets-core, any 'worklet' function that does not capture any outer variables is not recognized as a worklet by worklets-core.
Calling such a function from inside another worklet that runs on a worklets-core context throws:
Regular javascript function 't' cannot be shared. Try decorating the function with the 'worklet' keyword to allow the javascript function to be used as a worklet.
('t' is just the minified function name in a release bundle.)
We hit this through react-native-filament: EntitySelector's MaterialModifier worklet calls the module-level applyMaterialParameters worklet, which captures nothing, so every model with materialParameters fails on the worklet thread.
Environment
- react-native: 0.88.0 (New Architecture, Hermes)
- react-native-worklets-core: 1.6.3
- react-native-worklets: 0.13.0 (its Babel plugin is active)
- react-native-filament: 1.9.0 (where we first saw it; 1.11.0 has the same code)
- Babel plugins:
plugins: [ ['react-native-worklets-core/plugin', { processNestedWorklets: true }], 'react-native-worklets/plugin', ]
Minimal reproduction
import { Worklets } from 'react-native-worklets-core'
// Captures nothing from the outer scope
const double = (x: number) => {
'worklet'
return x * 2
}
const context = Worklets.createContext('repro')
// The worklet passed to runAsync captures `double`
context
.runAsync(() => {
'worklet'
return double(21) // <- throws "Regular javascript function '...' cannot be shared"
})
.then(console.log)
If double captures any outer variable (so it gets a __closure), the call works.
What the transpiled code looks like
With the react-native-worklets plugin (0.13.0, and the same in the 0.14 nightlies), a worklet that captures nothing is emitted without __closure, and the hash is a number literal:
var double = function double_Factory([_worklet_123_init_data]) {
const double = function (x) { return x * 2 }
double.__workletHash = 123 // number, not string
double.__initData = _worklet_123_init_data // { code: "(function ...)" }
return double // no __closure assignment
}([_worklet_123_init_data])
The plugin only emits __closure when closureVariables.length > 0 (see plugin/index.js), so leaving it out is intended behavior there, not a bug.
Root cause
In cpp/WKTJsiWorklet.h:
isDecoratedAsWorklet()returnstrueright away only when__workletHashis a string. Otherwise it requires__closureto be present, so a numeric hash with no__closureis treated as a regular function.createWorklet()returns early when__closureisundefined/null, so even if detection passed, the worklet would not be created.
JsiObjectWrapper::setFunctionValue() then wraps the function in a host function that throws the "cannot be shared" error when called.
Suggested fix
Treat a function as a worklet when __workletHash is a number and __initData.code is a string, and use an empty closure when __closure is missing. Code generated for a worklet with no captures never reads this.__closure, so an empty array is safe.
I have a small patch for this and can open a PR.
Possibly related
#258 reports release builds failing with "is not a Worklet" when the Reanimated plugin and the worklets-core plugin are used together. It might be the same root cause, but I haven't verified that.
- Lingua principale
- C++
- Stelle
- 791
- Fork
- 66
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di margelo/react-native-worklets-core
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 45/100
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
margelo/react-native-worklets-core#271 · 1 commento ·
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 35/100
margelo/react-native-worklets-core#269 · 2 reazioni ·
-
Unable to download JS bundleAperta
Difficoltà 3/5 1-2 giorni Idoneità per principianti 35/100
margelo/react-native-worklets-core#268 · 2 commenti ·
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 72/100
margelo/react-native-worklets-core#267 · 1 commento · 1 reazione ·
Tutte le issue di margelo/react-native-worklets-core
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
ROCm/rocm-libraries#14027 ·
I maintainer di solito rispondono entro 2 giorni
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 73/100
Qiskit/qiskit-aer#2487 ·
I maintainer di solito rispondono entro 1 giorno
-
GUI
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 78/100
qbittorrent/qBittorrent#25104 ·
I maintainer di solito rispondono entro 2 giorni
-
P2: A timed rotation maneuver does nothing on a ship that had an earlier timed lateral maneuverAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
scp-fs2open/fs2open.github.com#7914 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
I maintainer di solito rispondono entro 2 giorni