`MapboxRoutingProvider` crashes when concurrent first route requests initialize `routerClient`

Aperta
  • Qualcosa non va?
#4,852 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
68/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
swift
Ambito
mobile

Direzione di ricerca

Locate MapboxRoutingProvider and inspect routerClient, calculateRoutes, and doRequest, focusing on how concurrent requests reach the lazy initializer. Verify the fix by exercising concurrent first calls on one provider and confirming that a single RouterClient is initialized without EXC_BAD_ACCESS.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

We are seeing an EXC_BAD_ACCESS in Mapbox Navigation iOS 3.26.0 when multiple route requests start concurrently against the same MapboxNavigationProvider / MapboxRoutingProvider.

The crash occurs in MapboxRoutingProvider.routerClient while evaluating its lazy initializer:

private lazy var routerClient: RouterClient = {
    let factory = configuration.nativeHandlersFactory
    let router = RouterFactory.build(
        for: configuration.source.nativeSource,
        tilesManager: factory.tilesManager,
        config: factory.configHandle(),
        historyRecorder: factory.historyRecorderHandle
    )
    return Environment.shared.routerClientProvider.build(router)
}()

We confirmed two concurrent threads entering RouterFactory.build during the first access. This races the lazy initialization and produces:

EXC_BAD_ACCESS
objc_retain
closure #1 in MapboxRoutingProvider.routerClient.getter
MapboxRoutingProvider.routerClient.getter
MapboxRoutingProvider.doRequest(...)
MapboxRoutingProvider.calculateRoutes(...)

Our route-preview UI starts concurrent requests for walking, driving, and cycling. The app safely caches a single MapboxNavigationProvider, but each request calls calculateRoutes independently. MapboxRoutingProvider is declared @unchecked Sendable, creates an unstructured Task per request, and has no actor isolation, lock, or other synchronization around routerClient.

withCheckedContinuation correctly bridges each native callback, but it does not serialize separate calls to doRequest.

Expected behavior: concurrent calls to calculateRoutes on one provider should safely share a single initialized RouterClient.

Current behavior: concurrent first calls can initialize routerClient simultaneously and crash.

Could you please protect routerClient initialization/access with actor isolation or explicit synchronization, rather than relying on an unsynchronized lazy var?

Lingua principale
Swift
Stelle
919
Fork
329
Merge medio
2g 51m
PR unite (30g)
5

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di mapbox/mapbox-navigation-ios

Tutte le issue di mapbox/mapbox-navigation-ios

Issue simili

Altre issue su Swift

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.