Android: surface snapshot metadata validation errors instead of generic Snapshot refresh failed

Aperta
#165 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
56/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
android, ocaml

Direzione di ricerca

Read shared/src/logseq/core/snapshot_download.ml at the metadata resolver and trace where its validation error reaches Android's sync status and Check log. Reproduce the missing- t metadata response described in the issue and confirm the specific reason is surfaced without exposing credentials or payloads; the existing upstream server includes t, so use the stated older-server case when checking the failure path.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Summary

Please preserve the underlying snapshot metadata validation reason in Android's sync status / Check log. A deterministic bootstrap contract mismatch currently appears only as Sync failed / Snapshot refresh failed, with repeated download-start events and no actionable reason visible to the user.

Scope: the missing field in this reproduction comes from an intentionally old, locally patched self-hosted server. This is not a claim that the current upstream server still omits the field: the current handler and the current upstream container image include it. Strict cursor validation should remain enabled.

Installed app

  • Pixel Fold, native Android app com.logseq.logseq
  • Version 2.0.2, versionCode 1701
  • Settings revision cbff0ec5, resolved to cbff0ec53026e139aa8bd2ac5f381b16481086ff (Add Android account deletion and privacy links)
  • Existing E2EE cloud graph accessed through a self-hosted HTTPS graph server
  • Old server source revision abdf4775a3ad99e526abebca6042deecb541f017, with a separate local transaction-handling patch

Reproduction

  1. Configure an older self-hosted server whose successful /sync/<graph-id>/snapshot/download JSON has this shape:

    {"ok":true,"key":"stream/<graph-id>.snapshot","url":"https://<sync-origin>/sync/<graph-id>/snapshot/stream"}
    
  2. On the installed native build, select a graph requiring initial snapshot bootstrap (cursor=-1).

  3. Open Sync status, tap Sync now, and wait at least 35 seconds.

  4. Inspect Sync status and Settings → Check log.

The observed UI remains:

Status: Sync failed
Connection: Disconnected
Local changes: Not saved
Remote tx: Unavailable

Check log's Last error is Snapshot refresh failed. PID-scoped Android logs show GraphLifecycle: snapshot.download.start repeatedly, approximately 30 seconds apart, without the specific metadata validation reason. This failure was reproduced by an ADB UI script which taps Sync now, waits 35 seconds, and exits 1 for the failed/disconnected state. No app data was cleared.

Source-matched cause and expected diagnostics

The exact installed resolver requires t to be an integer >= 0 and otherwise returns Snapshot cursor metadata is invalid before returning a stream download plan:

https://github.com/logseq/mobile/blob/cbff0ec53026e139aa8bd2ac5f381b16481086ff/shared/src/logseq/core/snapshot_download.ml

The production metadata response was independently authenticated and checked: HTTP 200, fields ok, key, url, no t. Successful HTTP and a working stream are not sufficient to satisfy the native metadata contract.

Please expose that specific reason, ideally with a message indicating an incompatible/older sync server, rather than only Snapshot refresh failed. This would distinguish a protocol contract mismatch from timeouts, authentication, E2EE, and import failures without exposing payloads or credentials.

Current upstream status / limits

The current upstream Logseq handler returns :t (t-now self). A read-only metadata probe against an isolated copy of the graph running ghcr.io/yshalsager/logseq-selfhost-sync:latest passes the installed native metadata contract and returns the actual current cursor.

That probe verifies metadata only. It does not establish Android stream import/decryption success. No graph contents, credentials, key material, private hostnames, raw UI XML, or raw Android logs are attached.

Lingua principale
OCaml
Stelle
9
Fork
2
Merge medio
2h 26m
PR unite (30g)
116

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di logseq/mobile

Tutte le issue di logseq/mobile

Issue simili

Altre issue su Backend & API Design

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.