System settings: Download tab fails with int() argument must be ... not 'NoneType' - spices server serves JSON without Content-Length
I maintainer di solito rispondono entro 8 giorni
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 2/5
- Tempo stimato
- 1-3 ore
- Idoneità per principianti
- 58/100
Direzione di ricerca
Read files/usr/share/cinnamon/cinnamon-settings/bin/Spices.py, focusing on _url_retrieve() and _update_progress(), then reproduce the Download tab failure with a chunked response that has no Content-Length header. The issue provides the specific changes and reports that fetching applet index.json and thumbnails succeeds afterward; check whether this 6.6.x fix is still needed, since the issue says master was rewritten and is unaffected.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary
Opening the "Download" tab in System Settings -> Applets (also Desklets, Extensions, Actions, Themes) shows an error dialog:
An error occurred while trying to access the server. Please try again in a little while.
Details: int() argument must be a string, a bytes-like object or a real number, not 'NoneType'
The list of available spices can never be loaded - ~/.cache/cinnamon/spices/<type>/index.json stays empty (the partially downloaded file is removed on error).
Reproduce
- cinnamon-settings -> Applets -> Download tab (this triggers
refresh_cache()). - Observe that the request to
cinnamon-spices.linuxmint.com/json/applets.jsonhas noContent-Lengthheader when made through requests/urllib3:
curl -sS -D - -o /dev/null "https://cinnamon-spices.linuxmint.com/json/applets.json" | grep -iE 'HTTP/|content-length|transfer-encoding'
# HTTP/2 200 ... (HEAD reports content-length)
python3 -c "
import requests
r = requests.get('https://cinnamon-spices.linuxmint.com/json/applets.json', stream=True)
print(r.status_code, r.headers.get('content-length'), r.headers.get('transfer-encoding'))"
# 200 None chunked <-- no content-length when requested with Accept-Encoding: gzip
The server now serves the JSON indexes with Transfer-Encoding: chunked + Content-Encoding: gzip, so the content-length header is absent.
Root cause
files/usr/share/cinnamon/cinnamon-settings/bin/Spices.py:
def _url_retrieve(self, url, outfd, reporthook, binary):
...
response = requests.get(url, proxies=proxy_info, stream=True, timeout=15)
assert response.ok
totalSize = int(response.headers.get('content-length')) # <-- None -> TypeError
The exception is caught in _download() and surfaced as "An error occurred while trying to access the server...".
Fix
--- a/files/usr/share/cinnamon/cinnamon-settings/bin/Spices.py
+++ b/files/usr/share/cinnamon/cinnamon-settings/bin/Spices.py
@@ -420,7 +420,8 @@ class Spice_Harvester(GObject.Object):
response = requests.get(url, proxies=proxy_info, stream=True, timeout=15)
assert response.ok
- totalSize = int(response.headers.get('content-length'))
+ content_length = response.headers.get('content-length')
+ totalSize = int(content_length) if content_length is not None else 0
for data in response.iter_content(chunk_size=blockSize):
Plus a guard in _update_progress so the progress bar does not run away when the total size is unknown:
@@ -328,7 +328,12 @@
text = _("Downloading images:") + f" {current}/{total}"
self._set_progressbar_text(text)
else:
- fraction = count * blockSize / float((totalSize / blockSize + 1) * blockSize)
+ if totalSize > 0:
+ fraction = count * blockSize / float((totalSize / blockSize + 1) * blockSize)
+ else:
+ # No content-length header (chunked response) - fall back to a
+ # progress estimate based on the number of chunks received.
+ fraction = count / float(count + 1)
self._set_progressbar_fraction(fraction)
Verification with the patched code: the real Spice_Harvester('applet').refresh_cache() downloads index.json (275 applets, 674698 bytes) plus all thumbnails without errors. Static assets (icons/screenshots) are still served with Content-Length - only the JSON index downloads break.
Environment
- Cinnamon 6.6.7 (Gentoo Linux), Python 3.14, requests 2.34.2 / urllib3 2.7.0
Note
In master, Spices.py was rewritten on top of cinnamon.harvester (non-streamed requests), which is not affected. Suggest backporting the fix to 6.6.x, otherwise this can be closed as fixed-in-master.
- Lingua principale
- JavaScript
- Stelle
- 5.7k
- Fork
- 941
- Merge medio
- 6g 18h
- PR unite (30g)
- 12
Preparare l'ambiente
Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di linuxmint/cinnamon
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
I maintainer di solito rispondono entro 8 giorni
-
BUG
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 8 giorni
-
Sound applet: seek bar jumps back after seeking when player resends metadata (e.g. mpDris2/MPD)ApertaBUG
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
I maintainer di solito rispondono entro 8 giorni
-
Menu applet omits descriptions from search-provider resultsForse già presa @ah682 l’ha presa 9 giorni fa. ApertaBUG
Difficoltà 2/5 1-3 ore Idoneità per principianti 66/100
linuxmint/cinnamon#14104 · 2 commenti ·
I maintainer di solito rispondono entro 8 giorni
-
xapp-status applet: status icon labels are ellipsized to "..." when the panel zone is a fraction of a pixel shortForse di nuovo libera @Priyeshshrivastav l’ha presa 15 giorni fa e non c’è nessuna pull request aperta. Aperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
linuxmint/cinnamon#14096 · 1 commento ·
I maintainer di solito rispondono entro 8 giorni
Tutte le issue di linuxmint/cinnamon
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
mailcow/mailcow-dockerized#7677 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
gcivil-nyu-org/team5-mon-fall26#145 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
-
needs discussion
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
openfga/openfga.dev#1436 · 1 commento ·
I maintainer di solito rispondono entro 2 giorni