User API lists collaborators' channel ids the requester can't view

Aperta
#6,420 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
1/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python
Ambito
api, backend, security

Direzione di ricerca

Read contentcuration/contentcuration/viewsets/user.py, especially UserViewSet and annotate_queryset, and review the strategy in issue #6398. Add regression tests for a co-editor whose other channel is hidden from the requester and for the requester's own record; done means collaborator channel IDs are filtered while own channel lists and sharing views keep working. The issue says it is not open for contribution.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

DEV: backend

❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.

Overview

GET /api/user/ returns, for every user the requester can see, the ids of all channels that user edits or views. A user can see their co-editors and co-viewers, so they get the ids of their collaborators' other channels, including ones they have no access to.

Complexity: Low
Target branch: hotfixes

Context
  • UserViewSet returns editable_channels and view_only_channels, which annotate_queryset aggregates over all of each user's channels.
  • Reproduced: a co-editor's GET /api/user/ response listed the other editor's full editable_channels and view_only_channels, including channels the requester couldn't open.
The Change
  • For any user other than the requester, editable_channels and view_only_channels should only list channels the requester can view, following the strategy in #6398. The frontend's sharing views read these fields, and should keep working.
Acceptance Criteria
General
  • For another user's record, editable_channels and view_only_channels contain only channels the requester can view.
  • The requester's own record still lists all their channels.
  • The channel sharing views show the same collaborators as before.
Testing
  • Regression tests cover a co-editor with a channel the requester can't view, and the requester's own record.

AI usage

I chose which audit findings belong in #6398 and set the access pattern. Claude Code found and reproduced this gap and drafted this issue.

Lingua principale
Python
Stelle
212
Fork
321
Merge medio
1g 7h
PR unite (30g)
14

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di learningequality/studio

Tutte le issue di learningequality/studio

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.