Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

database-restore:create posts to the plural /restores path; the API endpoint is singular /restore

Aperta
  • Qualcosa non va?
#207 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
40/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
laravel, php
Ambito
api, databases

Direzione di ricerca

Inizia con CreateDatabaseRestoreRequest::resolveEndpoint() e CreateDatabaseRestoreRequestData::toRequestData(), quindi confronta la richiesta di restore con la richiesta POST /snapshots funzionante. Riproduci la chiamata con il comando curl e l’ID della richiesta forniti; il lavoro è completato quando POST /api/databases/clusters/{cluster}/restores accetta l’autenticazione tramite token, restituisce JSON e crea il restore senza reindirizzamento.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Description

POST /api/databases/clusters/{cluster}/restores returns HTTP 302 redirecting to the dashboard instead of a JSON response, so database-restore:create cannot create a restore even once the client-side problems are out of the way.

This is a different failure from #183. That one was the Form.php fatal, fixed by #187 and shipped. With that fix in place the command now reaches the API, and the API redirects it:

{"error":true,"message":"Laravel Cloud sent back a response we could not read: HTTP 200 from POST
https://cloud.laravel.com/api/databases/clusters/db-…/restores.
The body started with: <!DOCTYPE html> <html lang=\"en\"> <head> …"}
The redirect is specific to this one route

Same token, same headers, same cluster, in the same session:

Request Result
GET /api/databases/clusters/{id} 200 JSON
GET /api/databases/clusters/{id}/snapshots 200 JSON
POST /api/databases/clusters/{id}/snapshots 200 JSON, snapshot created successfully
POST /api/databases/clusters/{id}/restores 302 to https://cloud.laravel.com

So this is not authentication, not the token, not the Accept/Content-Type pair, and not POST in general. POST /snapshots works with exactly the same setup that makes POST /restores redirect. It looks like the restores route is falling through to a web-session redirect rather than being handled as a token-authenticated API route.

Reproduction
curl -i -X POST "https://cloud.laravel.com/api/databases/clusters/${CLUSTER}/restores" \
  -H "Authorization: Bearer ${TOKEN}" \
  -H "Accept: application/vnd.api+json" \
  -H "Content-Type: application/vnd.api+json" \
  -d '{"name":"scratch-verify","database_snapshot_id":"'"${SNAPSHOT}"'"}'

Response:

HTTP/2 302
location: https://cloud.laravel.com
content-type: text/html; charset=utf-8
x-amzn-requestid: adc0a260-e499-4bf0-8234-fa2676dd1186
x-amzn-trace-id: Root=1-6a8d22d9-773df68f36f80dd4794da950;Parent=0021dc61b07a0ccf;Sampled=0

The payload shape matches App\Client\Requests\CreateDatabaseRestoreRequestData::toRequestData() (name, database_snapshot_id, restore_time) and the endpoint matches CreateDatabaseRestoreRequest::resolveEndpoint(), so the CLI's own request is being redirected the same way. Reproduced via curl and via the CLI itself.

No restore cluster is created, and the source cluster is unaffected.

Environment
  • laravel/cloud-cli v0.5.2, with #183 / #187 already in place
  • PHP 8.4 / macOS (darwin 25.5.0)
  • Cluster type laravel_mysql_84, region ap-southeast-2
  • Snapshot used: type: manual, status: available, created via POST /snapshots minutes earlier
Impact

Restoring a snapshot is the documented way to get a copy of a production database without exposing production itself (Laravel MySQL, "How to download a backup"): restore a snapshot to a new cluster, enable public access on the copy, dump from it, delete the copy.

With this route redirecting, that workflow cannot be scripted at all. The remaining option is enabling the public endpoint on the production cluster and dumping from that, which is exactly what the documented workflow exists to avoid. We are verifying that backups are restorable, and creating snapshots works while restoring them does not, so the half that actually matters cannot be exercised.

Request

Could you confirm whether POST /api/databases/clusters/{cluster}/restores is expected to accept API-token auth, and if so route it as an API endpoint rather than redirecting? Request ID adc0a260-e499-4bf0-8234-fa2676dd1186 should identify the call in your logs.

Lingua principale
PHP
Stelle
47
Fork
11
Merge medio
17h 13m
PR unite (30g)
13

Preparare l'ambiente

Non abbiamo ancora controllato i file di configurazione di questo progetto. Parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di laravel/cloud-cli

Tutte le issue di laravel/cloud-cli

Issue simili

Altre issue su PHP

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.