Blob v2 raw file reader fails on files with anonymous descriptor child IDs

Aperta
#10,944 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
47/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
rust
Ambito
backend, data

Direzione di ricerca

Start by comparing the raw-file reader path in rust/lance-file/src/reader.rs with normalize_blob_footer_schema in rust/lance-file/src/concat.rs, which the issue says is only used by concatenation. Trace how Schema::try_from(&Fields) handles Blob v2 descriptor children with parent_id == -1. Add reader-side normalization for existing files, then cover the C and native writers and readers, both projection modes, NULL and empty rows, an ordinary-column control, and a file from the current writer.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

A v2.2 file with one physical Blob v2 column (3 rows) fails through the ordinary raw-file reader. The failure reproduces with files written by both the C and native Rust writers, and with both the public C FileReader and the direct native Rust FileReader.

Pinned: Lance v14.0.2 (40f15ed1b71b66950961b175829fdf17a763f108).

Symptoms
  • Whole-schema projection: the footer reconstructs six top-level fields, giving [0,5,5,5,5,5]; the reader returns The projection specified the column index 5 but there are only 1 columns in the file (rust/lance-file/src/reader.rs:1174).
  • Explicit columns=["blob"]: projection [0] passes, but Blob is exposed as Struct([]); consuming the stream returns Structural validity has 3 entries for an array with 0 values (rust/lance-encoding/src/encodings/logical/primitive/field.rs:874).
  • An ordinary id column alongside Blob fails analogously with index 6 for two physical columns.
Root cause

Field::unloaded_mut copies the BLOB_V2_DESC_LANCE_FIELD children; their ids and parent_id are -1. The structural writer persists them, and read-side Schema::try_from(&Fields) treats every parent_id == -1 field as a root, so the five descriptor children become orphan top-level fields and the Blob parent loses its children.

normalize_blob_footer_schema handles this shape but is only used by concatenation (rust/lance-file/src/concat.rs:270). Dataset scanning has separate Blob projection handling, so dataset reads pass while the raw-file reader fails.

Requested fix

A reader-side normalization for already-written files. A writer-side ID fix alone cannot repair existing files.

Tests should cover: C and native writers × C and native readers; default and explicit projections; NULL/empty rows; an ordinary-column control; and a pre-existing file produced by the current writer.

Notes

As of lance-format/lance main 58e62bd546081357e2b8966e12ef9bb5c5debbb1 (2026-11-11), the reader path is unchanged and no official fix was found in the checked code.

Reproducer/evidence: lance-format/lance-c#167. Related: lance-format/lance-c#99, lance-format/lance-c#114, lance-format/lance-c#115, lance-format/lance-c#162.

Lingua principale
Rust
Stelle
7.3k
Fork
929
Merge medio
2g 22h
PR unite (30g)
572

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di lance-format/lance

Tutte le issue di lance-format/lance

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.