Beacon API: cap the slot a beacon_committee_subscriptions entry joins a subnet until

Aperta
#814 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 6 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
52/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
rust

Direzione di ricerca

Start with post_committee_subscriptions in crates/net/rpc/src/beacon/validator.rs and compare its slot handling with post_sync_committee_subscriptions in crates/net/rpc/src/beacon/sync_committee.rs. Read the referenced sync clamp test, then check the aggregator subnet join and expiry paths in crates/net/p2p/src/gossipsub/handler.rs. Done means future slots are capped or rejected at the stated epoch bound, the behavior is tested, and the outdated clause is removed from docs/rpc.md.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Problem. POST /eth/v1/validator/beacon_committee_subscriptions lets the caller choose how long the node stays on an attestation subnet, with no upper bound.

  • post_committee_subscriptions (crates/net/rpc/src/beacon/validator.rs:307-331) passes each aggregator entry's slot through as sent.
  • join_aggregator_subnets (crates/net/p2p/src/gossipsub/handler.rs:1156-1186) keeps the largest slot it has seen for a subnet.
  • leave_expired_aggregator_subnets (handler.rs:1251-1264) leaves the subnet only once that slot has passed.

So one request with is_aggregator: true and a far-future slot keeps the node subscribed until restart. That costs it bandwidth and gossip validation on that subnet. With 64 entries, one per subnet, it holds every attestation subnet. The sync committee endpoint does not have this gap: post_sync_committee_subscriptions clamps until_epoch to the end of the next sync committee period (crates/net/rpc/src/beacon/sync_committee.rs:320-338).

Why it is out of scope. lambdaclass/ethlambda#778 is docs-only. It documents the gap in docs/rpc.md's "What the servers trust" ("an attestation subnet's is not capped") and does not change it.

Fix. Clamp, or refuse with a 400, any slot past the last slot of the furthest epoch attester duties are served for. That epoch is epoch_upper_bound, the wall-clock or head epoch plus one (validator.rs:422-425, enforced by attester_duties at validator.rs:688). A validator client cannot hold a legitimate duty beyond it.

  • Model the change and its test on the sync clamp (subscriptions_group_by_subnet_keep_the_latest_epoch_and_clamp_it, sync_committee.rs:872).
  • Then drop the "not capped" clause from docs/rpc.md.
Lingua principale
Rust
Stelle
86
Fork
34
Merge medio
9g 20h
PR unite (30g)
77

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di lambdaclass/ethlambda

Tutte le issue di lambdaclass/ethlambda

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.