Migrate from deprecated Redirect Flows to Billing Requests (blocked on gocardless-pro SDK upgrade)

Aperta
  • Qualcosa non va?
#46 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
18/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Tranquilla
Stack tecnologico
java
Ambito
payments

Direzione di ricerca

The work lives in src/main/java/org/killbill/billing/plugin/gocardless/GoCardlessPaymentPluginApi.java: buildFormDescriptor around L403 and addPaymentMethod around L332 both call redirectFlows(). Start by confirming which gocardless-pro release on Maven Central exposes BillingRequestService, because pom.xml pins 3.10.0 and nothing can be written until that upgrade lands. Done when a mandate is created and completed through Billing Requests, the optional scheme parameter is wired through /checkout, countryCode is prefilled in buildCustomer, and the README walkthrough no longer documents Redirect Flows.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Problem

The plugin sets up mandates using the Redirect Flows API:

  • created in buildFormDescriptor — L403
  • completed in addPaymentMethod — L332

GoCardless has deprecated Redirect Flows in favour of Billing Requests. Redirect Flows are closed to new integrators and are slated for eventual withdrawal for existing ones.

Why this matters

A new GoCardless customer cannot use this plugin at all. They have no access to the Redirect Flows API, so buildFormDescriptor fails on the first call. This is not a future risk — it is the current state for anyone signing up today.

Existing integrators are on borrowed time, with no published withdrawal date.

Blocked by the pinned SDK

pom.xml pins com.gocardless:gocardless-pro:3.10.0, which predates Billing Requests entirely. The services in that jar are:

BankDetailsLookup, Creditor, CreditorBankAccount, Customer, CustomerBankAccount,
CustomerNotification, Event, Mandate, MandateImport, MandateImportEntry, MandatePdf,
Payment, Payout, PayoutItem, RedirectFlow, Refund, Subscription

There is no BillingRequestService. The SDK upgrade is a prerequisite, not an afterthought.

Also missing: scheme selection

While in this code path — the redirect flow is created without a scheme:

buildGoCardlessClient(context).redirectFlows().create()
    .withDescription(redirectFlowDescription)
    .withSessionToken(sessionToken)
    .withSuccessRedirectUrl(successRedirectUrl)
    .withPrefilledCustomer(customer).execute();

RedirectFlowCreateRequest.withScheme(...) exists in the SDK (ach, autogiro, bacs, becs, becs_nz, betalingsservice, pad, sepa_core) and is never called, so the scheme cannot be constrained — GoCardless infers it from whatever bank details the customer types. Leaving it unset is a defensible default, but it should be an option rather than an omission. Relatedly, buildCustomer does not prefill countryCode, which is one of the signals that drives the hosted page.

Proposed work

  1. Upgrade gocardless-pro to a version exposing Billing Requests.
  2. Reimplement buildFormDescriptor to create a Billing Request + Billing Request Flow and return the authorisation_url.
  3. Reimplement addPaymentMethod to complete against the Billing Request and extract the resulting mandate.
  4. Expose an optional scheme parameter through /checkout and buildFormDescriptor, defaulting to unset.
  5. Prefill countryCode in buildCustomer.
  6. Update the README — the current walkthrough documents the Redirect Flow endpoints and uses a US routing number / checking account as its worked example.

Interacts with #45: Billing Requests are also the path to multiple mandates per customer.

Lingua principale
Java
Stelle
4
Fork
7
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di killbill/killbill-gocardless-plugin

Tutte le issue di killbill/killbill-gocardless-plugin

Issue simili

Altre issue su Java

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.