[JENKINS-59139] don't set GIT_LFS_SKIP_SMUDGE=1 anymore while cloning with git 2.15+

Aperta
#1,601 11 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
42/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Ferma
Stack tecnologico
git, java
Ambito
devtools

Direzione di ricerca

Inizia esaminando il commit 853603cccd4434b116ef9b8e094c3f5b815aa75a e il percorso di git clone che imposta GIT_LFS_SKIP_SMUDGE=1. Verifica il comportamento del clone per Git 2.15+ e Git LFS, quindi rimuovi questa impostazione preservando il comportamento opzionale di "Git LFS pull after checkout" e convalida i test pertinenti.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

component:git-client-plugin imported-jira-issue priority:minor resolution:unresolved

Since commit 853603cccd4434b116ef9b8e094c3f5b815aa75a, we set GIT_LFS_SKIP_SMUDGE=1  to improve performance, and require users to add the "Git LFS pull after checkout" additional behaviour to resolve pointers. 

This was mostly done because git clone performance was pretty bad with the smudge filter enabled, and in some configurations, (ssh clone URLs), git lfs pull didn't work.

Since then, a lot has improved:

Clone performance through the smudge filter has improved since https://github.com/git-lfs/git-lfs/pull/2511.

Backends should support the git-lfs-authenticate dance as described in https://github.com/git-lfs/git-lfs/blob/master/docs/api/authentication.md#ssh, which retrieves a temporary authorization token to do the clone over https.

I propose to just do a git clone without setting GIT_LFS_SKIP_SMUDGE=1. Most systems should have done a git lfs install before, so they will resolve the lfs pointers during a clone. We can keep the "Git LFS pull after checkout" additional behaviour, for systems that don't have setup global smudge filters via git lfs install.


Originally reported by flokli, imported from: don't set GIT_LFS_SKIP_SMUDGE=1 anymore while cloning with git 2.15+
  • status: Open
  • priority: Minor
  • component(s): git-client-plugin
  • resolution: Unresolved
  • votes: 1
  • watchers: 11
  • imported: 20251211-071809
Raw content of original issue

Since commit 853603cccd4434b116ef9b8e094c3f5b815aa75a, we set GIT_LFS_SKIP_SMUDGE=1  to improve performance, and require users to add the "Git LFS pull after checkout" additional behaviour to resolve pointers. 

This was mostly done because git clone performance was pretty bad with the smudge filter enabled, and in some configurations, (ssh clone URLs), git lfs pull didn't work.

Since then, a lot has improved:

Clone performance through the smudge filter has improved since https://github.com/git-lfs/git-lfs/pull/2511.

Backends should support the git-lfs-authenticate dance as described in https://github.com/git-lfs/git-lfs/blob/master/docs/api/authentication.md#ssh, which retrieves a temporary authorization token to do the clone over https.

I propose to just do a git clone without setting GIT_LFS_SKIP_SMUDGE=1. Most systems should have done a git lfs install before, so they will resolve the lfs pointers during a clone. We can keep the "Git LFS pull after checkout" additional behaviour, for systems that don't have setup global smudge filters via git lfs install.

Lingua principale
Java
Stelle
152
Fork
404
Merge medio
2g 7h
PR unite (30g)
5

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di jenkinsci/git-client-plugin

Tutte le issue di jenkinsci/git-client-plugin

Issue simili

Altre issue su Java

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.