blockchaintest: blocks are executed from the decoded JSON fields, so the block RLP body is never validated against its header

Aperta
#1,726 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
38/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
cpp

Direzione di ricerca

The runner currently applies blockchain_test blocks from the JSON decoded fields (blockHeader, transactions, uncleHeaders, withdrawals) instead of decoding the rlp bytes and checking that body against the header. Find where fixtures are loaded and blocks executed, then decode rlp as [header, txs, ommers, withdrawals] and fail when that body does not match the committed transactionsTrie (and related header fields). Done when a fixture whose rlp body was edited (last tx dropped) is rejected while an unedited multi-tx blockchain_test still passes.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Context

While running the Merkle Patricia Trie structural test suite of https://github.com/ethereum/execution-specs/pull/3600 against several clients, I corrupted fixtures on purpose to check that each runner rejects them. That surfaced which part of a blockchain_test fixture evmone consumes.

A fixture block carries the block twice: rlp, the canonical bytes, and the sibling fields blockHeader, transactions, uncleHeaders, withdrawals, documented as "Decoded block header fields included in the block RLP" and "List of decoded transactions included in the block RLP". The consumption procedure says to decode rlp (step 7.2) and then apply "the current decoded block" (step 7.3).

So a fixture whose RLP body disagrees with the header contained in that same RLP is consistent on the JSON side and passes.

Evidence

One fixture, one block, two transactions. Two edits, each self-consistent on its own side:

A. Remove the last transaction from the block RLP body only, leaving blockHeader (including transactionsTrie) and the JSON transactions untouched.

B. Remove the last transaction from the JSON transactions array only, leaving rlp untouched.

A runner that follows 7.2 and 7.3 fails A and passes B. evmone passes A and fails B. Of eight runners I tried the same pair on, six (go-ethereum, erigon, reth, Nethermind, nimbus-eth1, Besu) fail A and pass B; evmone and ethrex invert it.

Reproduction

Take any blockchain_test fixture with a block holding at least two transactions, decode blocks[0].rlp as [header, txs, ommers, withdrawals], drop the last element of txs, re-encode, and write it back to rlp without touching the other fields. Then

evmone test <dir>

It passes; per steps 7.2 and 7.3 it should fail, because the decoded block's transactions do not hash to the transactionsTrie committed in its own header.

Fixtures to reproduce with: uv run fill tests/mpt/ --clean on the branch of ethereum/execution-specs#3600, or any existing multi-transaction blockchain_test.

Lingua principale
C++
Stelle
979
Fork
340
Merge medio
12h 16m
PR unite (30g)
25

Preparare l'ambiente

  • Include un Dockerfile o un file Docker Compose
  • Nessun modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di ipsilon/evmone

Tutte le issue di ipsilon/evmone

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.