Show where an unjournaled review comment came from when REVIEW blocks on it

Aperta
  • Qualcosa non va?
#416 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
github, python
Ambito
developer-experience

Direzione di ricerca

Start by reading read_context.py and docs/agent-guides/secrets-and-logging.md, then trace how status gathers local state and GitHub data for a D9.6 block. Define a read-only report that presents the listed evidence without naming an author, and test with a fake GitHub and two state directories. Done means the journal match and later commits are reported as specified and the tree is unchanged.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement

When REVIEW blocks on a round comment the controller did not journal (ADR 0004 D9.6), the reason gives the comment's URL and nothing else. Working out who posted the comment in #387 (RCA) meant reading state files, run logs, the OpenCode database, agent transcripts, git objects and GitHub timelines by hand. Yet every fact that settled the question is one the controller can read itself:

  • the comment's created_at, compared with this run's creation and its reviewer launch;
  • whether any state on this checkout journaled the comment, across the standalone state directories and the scheduler namespaces;
  • the PR's other ai-review-result markers, with their rounds and HEADs;
  • the commits pushed to the PR after the comment, with their author identity and time offset;
  • the PR's ai-implementation marker, and the run that owns the PR if #414 adds one.

Desired outcome

A read-only report of those facts for a D9.6 block, for example in status --json and in the text status prints. It presents evidence and does not name an author (D9.3). It never adopts, deletes or writes anything.

Constraints

  • Read-only: GitHub GETs and local reads, and no lock beyond what status takes today.
  • Comment bodies and commit messages are untrusted data. They are bounded and redacted the way read context is (read_context.py, docs/agent-guides/secrets-and-logging.md).

Acceptance criteria

  • With a fake GitHub and two state directories, one of which journaled the comment, the report names that directory.
  • For a foreign comment, the report shows no journal match and lists the later commits.
  • Nothing is written: the tree is identical before and after.

Dependencies

  • Coordinates with #374: its recovery action package could carry this report as its D9.6 entry.
  • Uses #414's owner field when it exists, but does not depend on it.

Priority: P1.

Lingua principale
Python
Stelle
0
Fork
0
Merge medio
5h 19m
PR unite (30g)
106

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di iceboundrock/AutoForge

Tutte le issue di iceboundrock/AutoForge

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.