Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Mark the ADR passages that still reserve state protocol 6 for #126 as superseded by #23's numbering decision

Aperta Adatta ai principianti
  • Qualcosa non va?
#304 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
75/100
Tipo di issue
Documentazione
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
markdown, python
Ambito
documentation

Direzione di ricerca

Leggi i passaggi citati negli ADR 0004, 0006 e 0007, quindi confrontali con l’ADR 0003 e la sezione “Numbering a new protocol” della guida di stato dopo l’unione della PR #296. Modifica solo i passaggi elencati per indicare che la vecchia prenotazione è stata superata dalla decisione del #23 del 2026-10-23 e rimuovi da D6.2 l’attività #126 completata. Esegui make check; il lavoro è terminato quando grep, in base ai criteri di accettazione, non trova alcuna prenotazione non contrassegnata.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Artifact: follow-up issue from the review of PR #296 (review summary, "Observations"). It is the only copy.

Problem

On 2026-10-23, #23 released the reservation of state protocol 6 for #126: label 6 stays skipped for good, and a new protocol takes N + 1 from main when its PR is ready to merge. PR #296 writes that rule into docs/agent-guides/state-and-recovery.md ("Numbering a new protocol") and updates the state.py comment and the tests/test_state.py docstrings that called 6 "reserved for #126".

Four ADR passages still describe 6 as reserved for #126, with no mark that this is no longer true (line numbers on main at a6e0c95):

  • docs/adr/0004-authority-boundary-and-typed-external-effects.md
    • :2409-2411, D13.1: "never takes the 5 → 6 that #23 reserves for #126". The state guide and ADR 0007 D6.2 cite D13.1 as the numbering rule, so a reader may take this sentence as current.
    • :2510, D13.9 (#211): "never 6 (reserved for #126)".
    • :2527, D13.10 (#243): "It is never 6 (reserved for #126)".
  • docs/adr/0006-candidate-validation-evidence-and-review-certificates.md:1582 (§5.1): "#160's bump has landed as protocol 7, with 6 reserved for #126 (D15.2)."
  • docs/adr/0007-sdk-providers-isolated-helpers-and-interaction-contract.md
    • :77-80, "What does not exist": "Label 6 is reserved for #126 and refused as unknown" (a snapshot taken at protocol 9).
    • :885-886, D6.2: "#126 updates the comments that call it 'reserved for #126'". Once PR #296 merges, no code comment says so any more, so this assignment is done and should not remain a task for #126.

ADR 0003 (:661-662) and ADR 0007 D6.2's first bullet and :1645 already say that label 6 stays skipped. They need no change.

Why it is not fixed in PR #296

PR #296 records two maintainer decisions in the README, the state guide, one code comment and two test docstrings. #23's decision scoped its documentation change to state-and-recovery.md. Editing accepted ADRs is a separate change to files that PR does not touch, and the review raised it as a pre-existing observation, suggesting a follow-up.

Recommended direction

Amend in place, and do not rewrite history: each passage records a decision that was right when it was made. Follow ADR 0003's existing form, (no longer "5→6": label 6 stays skipped):

  • ADR 0004 D13.1, D13.9 and D13.10: keep the rules (one bump made alone, settled on #23 first), and mark "reserved for #126" as the state at the time. Name #23's 2026-10-23 decision and point to the state guide's "Numbering a new protocol" for the current rule.
  • ADR 0006 §5.1: same note on the status bullet.
  • ADR 0007 "What does not exist": mark it as a snapshot at protocol 9 and say label 6 is now skipped for good. D6.2: mark the comment update as done (PR #296), or drop that sentence.
  • Docs only: no change to code, state or tests, and no other ADR content.

Acceptance criteria

  • git grep -nE 'reserve[sd] for #126' docs matches only passages that say, in the same sentence or the next, that the reservation was released (#23, 2026-10-23).
  • Each amended passage names #23's decision or links the state guide's "Numbering a new protocol" section.
  • ADR 0007 D6.2 no longer assigns #126 a comment update that has already been made.
  • No decision content changes other than the protocol-6 reservation; make check passes.

Depends on PR #296 merging, since the state guide section it links is added there. Related: #23 (protocol numbering), #126.

Lingua principale
Python
Stelle
0
Fork
0
Merge medio
5h 42m
PR unite (30g)
64

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di iceboundrock/AutoForge

Tutte le issue di iceboundrock/AutoForge

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.