Allow connection pools to stop reusing an HTTP/2 connection before its keep-alive timeout
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 35/100
- Tipo di issue
- Funzionalità
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Attiva
- Stack tecnologico
- rust
- Ambito
- backend-api-design, networking
Direzione di ricerca
Inizia con il builder del client HTTP/2 e l’API hyper::client::conn::http2 descritta nella proposta, quindi segui il timeout del PING di keep-alive esistente e l’astrazione Timer. Esamina come il hyper-util legacy Client utilizzerebbe KeepAliveObserver e il suo PoisonPill per connessione. Il lavoro è completato quando l’API di notifica opzionale è esposta senza chiudere IO, annullare gli stream o modificare la readiness diretta di SendRequest.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Is your feature request related to a problem? Please describe.
An HTTP/2 connection can remain locally ready while its network path is unavailable. If no earlier transport or protocol error is observed, a connection pool can keep assigning new requests to that connection until the keep-alive PING timeout closes it.
A concrete scenario is a network failover or NAT/firewall state change after which new connections succeed but an existing connection remains unusable. The replacement path may have lost the old connection's state: a new TCP handshake can establish fresh state, while packets belonging to the old connection are silently dropped. If the client receives no FIN, RST, or other definitive error, the existing H2 connection can remain eligible for reuse locally even though it cannot make progress. Continuing to assign requests to it delays recovery despite a working path for new connections.
There are documented examples of the underlying network behavior:
- Google Cloud NAT documents that removing an external NAT IP without first draining it deletes the associated connection-tracking entries and drops all return traffic. With another usable NAT IP available, this provides a scenario where fresh connections can work while the old mapping no longer carries responses.
This does not assume that every network failover invalidates existing connections. A temporary interruption may also recover, which is why stopping reuse should not itself terminate existing streams.
There are two different policies involved: how long to keep existing streams alive during a recoverable interruption, and how long to keep assigning new work to that connection. Reducing the keep-alive timeout improves replacement latency, but also terminates existing streams earlier.
For example, an application may want to retain a 60-second PING timeout for existing streams while stopping reuse after an outstanding keep-alive PING has waited 5 seconds for an ACK. These are example settings, not proposed defaults.
Describe the solution you'd like
Would an optional reuse-timeout notification on the HTTP/2 client builder fit Hyper's API?
The proposal adds keep_alive_reuse_timeout(Option<Duration>) and a per-connection KeepAliveObserver. The observer would be exposed through hyper::client::conn::http2. A pool such as hyper-util's legacy Client could use the notification to retire its own connection entry.
- The option defaults to disabled.
- Its timer starts with the existing keep-alive PING timeout phase.
- An ACK ready before notification cancels the soft wait.
- On expiry, Hyper invokes a nonblocking observer once, outside the PING state lock.
- The original hard deadline continues to run. Notification does not close IO, send GOAWAY, cancel streams, or change direct
SendRequestreadiness. - A late ACK does not generate a reversal notification; the consuming pool owns its retirement policy.
The implementation uses Hyper's Timer abstraction and does not require changes to h2 or its dependency constraints.
Describe alternatives you've considered
Shortening the hard timeout also reduces interruption tolerance for existing streams. Application-level health requests or rebuilding an entire Client can provide a separate signal, but add another probe and broader connection-management logic. Deriving the signal from the existing PING wait keeps it specific to one connection.
Additional context
This issue tracks both parts of the proposal, with one implementation PR per repository:
- Hyper: expose the optional PING reuse-timeout notification through the HTTP/2 client API.
- hyper-util: add
http2_keep_alive_reuse_timeout(Option<Duration>)to the legacy Client builder and bind each H2 handshake to an observer holding only that connection'sPoisonPill. Existing pool checks then retire the entry without canceling its active streams.
The hyper-util setting would default to disabled. Its retirement policy would be irreversible even after a late ACK. Requests already checked out can race with retirement; neither PR migrates or replays requests or establishes connections proactively.
The hyper-util PR depends on the Hyper API. It can be reviewed as a draft using a companion checkout for validation, but must use an actual released Hyper version containing the API before it is ready to merge. Neither PR needs an h2 version pin.
- Lingua principale
- Rust
- Stelle
- 16.3k
- Fork
- 1.8k
- Merge medio
- 1g 23h
- PR unite (30g)
- 13
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di hyperium/hyper
-
C-feature
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 65/100
-
C-bug S-waiting-on-author
-
A-http2 C-bug
-
C-bug
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
-
A-client C-bug E-pr-welcome K-hyper-util
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
Tutte le issue di hyperium/hyper
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
TheLarkInn/aipm#2413 ·
-
documentation
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 90/100
alexgorbatchev/simple-ptt#15 ·
-
tooling
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
-
todo:ticket
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
taikoxyz/taiko-mono#22168 · 1 commento ·