TypeScript insert.text fails entirely on one extracted alias with a control character

Aperta
#362 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
70/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
backend

Direzione di ricerca

Read typescript/src/extraction/extractor.ts, especially assembleExtraction and its admit logic, then compare it with Python's handling described in #333. Make invalid aliases or entities produce a partial extraction failure instead of rejecting the entire insert, and verify the reproduced TypeScript case stores the valid entities with a warning.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

approved-for-pr area: extraction area: parity bug effort: S P2

What happens

In TypeScript, one extracted entity whose alias contains a control, NUL, or surrogate character fails the whole insert.text with invalid_argument. Nothing is inserted. Python handles the same reply differently (see #333: the chunk's entities fall back to Thing). Neither drops just that alias or entity, as _assemble does for other invalid items.

Reproduce

On main (5a277c9), embedded Kuzu:

import { mkdtempSync } from "node:fs";
import { tmpdir } from "node:os";
import { join } from "node:path";
import { KuzuStore, SelfGraph } from "@hydradb/selfgraph";

async function run(name: string, replies: Record<string, unknown[]>) {
  const llm = {
    async generate({ output }: { output: { shape: Record<string, unknown> } }) {
      const kind = Object.keys(output.shape)[0]!;
      return { [kind]: replies[kind] ?? [] };
    },
  };
  const g = new SelfGraph(new KuzuStore(join(mkdtempSync(join(tmpdir(), "sg-")), "g.kuzu")), { llm });
  try {
    const r = await g.insert.text("Ann works at Acme.");
    console.log(name, "ok", r.entities.map((e) => e.id));
  } catch (e) {
    console.log(name, (e as { code?: string }).code, (e as Error).message);
  } finally {
    await g.close();
  }
}

await run("bad alias", {
  entities: [
    { type: "Person", name: "Ann", aliases: null },
    { type: "Company", name: "Acme", aliases: ["Acme\u0007Inc"] },
  ],
  relations: [{ from_name: "Ann", type: "WORKS_AT", to_name: "Acme", event_time: null }],
});

Prints bad alias invalid_argument entity alias cannot contain control or surrogate characters. Python stores thing:ann and thing:acme with an extraction_partial_failure warning.

Cause

assembleExtraction in typescript/src/extraction/extractor.ts admits entities by checking only the type and name, so the bad alias reaches validateFacts, which rejects the batch. Dropping the alias (or the entity) inside admit with a warning, in both SDKs, would make them agree.

Lingua principale
TypeScript
Stelle
173
Fork
58
Merge medio
6h
PR unite (30g)
120

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di hydra-db/selfgraph

Tutte le issue di hydra-db/selfgraph

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.