Derive the GMS manifest from modular block declarations
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 35/100
- Tipo di issue
- Funzionalità
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Attiva
- Ambito
- machine-learning
Direzione di ricerca
Start by reading the work in PR #15017 and the modular pipeline declarations, especially InputParam, _workflow_map, and save_pretrained(). The issue presents several design options and says the related PR is still WIP, so first check the current implementation and discussion for an agreed direction. Done means modular blocks can provide the manifest data and newly saved models include gms.json.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
#15017 adds diffusers serve, which describes a model with a manifest: its tasks, inputs, parameters and outputs.
Right now modular pipelines go through the same path as standard pipelines: the blocks are converted into a __call__-like signature, and the manifest is guessed from argument names and type hints. That makes sense for standard pipelines, where the signature is all we have. But modular blocks are declarative, and we shouldn't need to guess for our own pipelines. I think the blocks can state most of this directly. A few ideas to start with:
1. InputParam.metadata
InputParam already has a metadata dict (Mellon uses it). It could carry what the manifest needs:
- the public name (
num_inference_steps→steps) - the kind: text, image, video, audio, mask, or a plain setting
- whether it's user-facing at all (
latents,timestepsare not)
2. Tasks from workflows
Tasks are guessed from whether there's an image / video input, so a model gets at most two. Blocks already declare their workflows and trigger inputs in _workflow_map. One task per workflow would also cover workflows triggered by other inputs, e.g. references in MiniMax-H3.
3. Require type_hint on user-facing inputs
A parameter's schema comes from its type hint (int → integer, list[float] → array of numbers). An input without one can't be described and is dropped today. We could require a type_hint on every InputParam that's exposed, and check it in the tests.
4. Reuse it in save_pretrained()
If the manifest comes from the blocks alone, the same function can run in save_pretrained() and write a gms.json next to modular_model_index.json. serve already picks up a gms.json from the model repo, so new models would ship with their manifest.
What the code could look like
A made-up sketch to show the idea, not tested. The "gms" key and its fields are placeholders.
# in a block
InputParam("num_inference_steps", type_hint=int, default=28, metadata={"gms": {"name": "steps"}})
InputParam("image", type_hint=PIL.Image.Image, metadata={"gms": {"type": "image"}})
InputParam("latents", type_hint=torch.Tensor) # no metadata, not exposed
def derive_manifest(model_id, blocks):
tasks = {}
for workflow, triggers in blocks._workflow_map.items():
# the blocks that run for this workflow, so only its own inputs are listed
workflow_blocks = blocks.get_workflow(workflow)
inputs, parameters = {}, {}
for param in workflow_blocks.inputs:
gms = (param.metadata or {}).get("gms")
if gms is None: # not user-facing
continue
name = gms.get("name", param.name)
if gms.get("type") in ("text", "image", "video", "audio", "mask"):
inputs[name] = {"type": gms["type"], "required": param.required or param.name in triggers}
else:
schema = type_hint_to_schema(param.type_hint) # int -> {"type": "integer"}
if param.default is not None:
schema["default"] = param.default
parameters[name] = schema
tasks[workflow] = {"inputs": inputs, "parameters": parameters}
return {"id": model_id, "tasks": tasks}
No rush since the PR is still WIP, opening this to collect ideas.
Posted by Claude on behalf of @yiyixuxu. The text was drafted together and approved by yiyixuxu.
- Lingua principale
- Python
- Stelle
- 34.9k
- Fork
- 7.5k
- Merge medio
- 3g 16h
- PR unite (30g)
- 65
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di huggingface/diffusers
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
huggingface/diffusers#15363 ·
I maintainer di solito rispondono entro 1 giorno
-
`ZImageImg2ImgPipeline` / `ZImageInpaintPipeline`: explicit height/width different from the input image raises RuntimeErrorForse già presa @chessing234 l’ha presa 1 giorno fa. Apertabug
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
huggingface/diffusers#15337 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
Multi-vector textual inversion uses only the first vector when the token has uppercase letters (transformers v5)Forse già presa @sunhouy l’ha presa 2 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
huggingface/diffusers#15313 ·
I maintainer di solito rispondono entro 1 giorno
-
TCDScheduler advances the generator on the final step of a strength-truncated custom scheduleForse già presa @SIDDARTHAREDDY8 l’ha presa 5 giorni fa. Apertabug
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
huggingface/diffusers#15288 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
unload_textual_inversion(token) leaves the extra tokens of a multi-vector embedding behind, so it can't be loaded againForse già presa @sohailshk l’ha presa 11 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
huggingface/diffusers#15211 · 3 commenti ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di huggingface/diffusers
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 73/100
I maintainer di solito rispondono entro 1 giorno
-
Unused loot bag group names left in dreamcraft en_US.langForse già presa Una pull request collegata a questa issue è aperta o già unita. ApertaStatus: Triage Suggestion
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 90/100
GTNewHorizons/GT-New-Horizons-Modpack#27789 ·
I maintainer di solito rispondono entro 1 giorno
-
bug frontend sev-5
Difficoltà 2/5 1-3 ore Idoneità per principianti 83/100
-
core good first issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
-
b4b code health next
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
ESCOMP/CTSM#4330 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno