[TRACKING ISSUE] Don't allow empty memberlist on cluster id changes [API-1215]

Aperta
#543 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
20/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Ferma
Stack tecnologico
java

Direzione di ricerca

Inizia leggendo la PR Java #20818 collegata e il problema correlato nell’issue #20264. Controlla la gestione della modifica di cluster-id e ClientHotRestartTest; il lavoro è completato quando i riavvii del cluster emettono gli eventi membro richiesti senza esporre una memberlist vuota, mentre il comportamento correlato di hot-restart continua a superare i test.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

The tracking issue for the Java side PR.

See https://github.com/hazelcast/hazelcast/pull/20818 for details.


When cluster id changed we were resetting member list
with an empty memberlist. It turned out that there are implementations
that assumes it will never be empty.

Following test failure is an example of it.
https://github.com/hazelcast/hazelcast/issues/20264

Instead of clearing the memberlist on cluster id change, we
are keeping the cluster id as part of the latest snapshot
to be able to fire correct events. In other words, on cluster restart
we need to fire removed events for all old members and added
events for all new members coming from restarted cluster.
We were achieving this via clearing memberlist and firing removed
events first. Then after some time new memberlist comes and we fire
added events. And the memberlist is empty during this period.
To prevent that, we have changed the logic. Now clusterUuid is
part of the logic. We don't clear the memberlist at all. Upon receiving,
an event, we compare existing and new clusterUuid. If they are different,
without comparing the members, we fire removed events for all existing
members, and added events for all new ones to achieve same behaviour.

Note that clearing memberlist on cluster id change was
introduced as a fix to https://github.com/hazelcast/hazelcast/pull/18245
So it is important not to break related ClientHotRestartTest

fixes https://github.com/hazelcast/hazelcast/issues/20264

Checklist:

  • Labels (Team:, Type:, Source:, Module:) and Milestone set
  • Label Add to Release Notes or Not Release Notes content set
  • Request reviewers if possible
  • Send backports/forwardports if fix needs to be applied to past/future releases
  • New public APIs have @Nonnull/@Nullable annotations
  • New public APIs have @since tags in Javadoc
Lingua principale
Python
Stelle
115
Fork
78
Merge medio
2g 23h
PR unite (30g)
2

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di hazelcast/hazelcast-python-client

Tutte le issue di hazelcast/hazelcast-python-client

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.