Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

ER: Remove unused `search` id query selectors

Aperta Adatta ai principianti
  • Qualcosa non va?
#8,803 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
1/5
Tempo stimato
Meno di un'ora
Idoneità per principianti
88/100
Tipo di issue
Refactoring
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
javascript
Ambito
frontend

Direzione di ricerca

Apri assets/js/current-projects.js e cerca i tre selettori che puntano all’id #search; confrontalo con _includes/current-projects.html per confermare che quell’id sia assente. Rimuovi ogni occorrenza di document.querySelector('#search'), quindi verifica che nel file JavaScript non rimangano selettori di questo tipo.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Complexity: Small Draft ER Issue Making: Level 1 P-Feature: Projects page ready for merge team role: back end/devOps size: 0.25pt
Emergent Requirement - Problem

In assets/js/current-projects.js, there are three query selectors that select an id named search. However, in _includes/current-projects.html, there is no id for search.

We must remove any query selectors for search in assets/js/current-projects.js since it is an unused id.

Issue you discovered this emergent requirement in
  • #8466
  • Issue was pointed out in this comment for the PR of the original issue
Date discovered

9/19/2026

Did you have to do something temporarily
  • YES
  • NO
Who was involved

@ldaws003 @castillios

What happens if this is not addressed

Any deprecated IDs may continue to bloat the codebase if left unaddressed.

Resources
Recommended Action Items
  • Make a new issue
  • Discuss with team
  • Let a Team Lead know
Potential solutions [draft]

  • Create a small issue that lists the 3 instances of document.querySelector('#search') and their corresponding line numbers to be removed from assets/js/current-projects.js.

  • In your issue body under the Instructions section, include before and after code snippets as follows:

    Line 105 before:

    const inputEl = document.querySelector('#search-desktop') || document.querySelector('#search-mobile') || document.querySelector('#search');

    Line 105 after removing document.querySelector('#search'):

    const inputEl = document.querySelector('#search-desktop') || document.querySelector('#search-mobile');

    Lines 344-348 before:

    function searchEventHandler(e){
    e.preventDefault();
    const input = document.querySelector('#search-desktop') || document.querySelector('#search-mobile') || document.querySelector('#search');
    let searchTerm = input ? input.value : '';

    Lines 344-348 after removing document.querySelector('#search'):

    function searchEventHandler(e){
    e.preventDefault();
    const input = document.querySelector('#search-desktop') || document.querySelector('#search-mobile');
    let searchTerm = input ? input.value : '';

    Lines 376-380 before:

    function searchCloseEventHandler(e){
    e.preventDefault();
    const input = document.querySelector('#search-desktop') || document.querySelector('#search-mobile') || document.querySelector('#search');
    if (input) input.value="";
}

    Lines 376-380 after removing document.querySelector('#search'):

    function searchCloseEventHandler(e){
    e.preventDefault();
    const input = document.querySelector('#search-desktop') || document.querySelector('#search-mobile');
    if (input) input.value="";
}

  • After listing implementation details, include an action item to test and verify that the changes still work by performing a search in both mobile and desktop views on the Projects and Projects-Check pages

  • Ensure your issue labels match this parent ER (with the exception of Issue Making: Level 1 and ER)

  • Once the overall issue has been drafted, in the sidebar under Relationships, add this ER as a parent to your issue

  • Review and if ready, apply the ready for merge team label

Lingua principale
JavaScript
Stelle
364
Fork
873
Merge medio
4g 23h
PR unite (30g)
11

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di hackforla/website

Tutte le issue di hackforla/website

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.