Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

WR Add Pull Request Instructions fails at artifact download (401) on its first ever run

Aperta
#2,231 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 4 giorni

@trillium ci sta già lavorando.

Dal 6/10/2026.

  • #2232 di @trillium — aperta

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
github-actions, javascript
Ambito
ci-cd, tooling

Direzione di ricerca

Start with .github/workflows/wr-pr-instructions.yml and the failing run linked in the issue; inspect the Download artifact step and the following step that reads its output. Replace the hand-rolled download with actions/download-artifact@v4, select the named artifact, and update the path as described. Done when a new PR run posts the comment without a 401 and still selects the correct artifact if another is added; pull request #2232 is already open.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Bug
Overview

.github/workflows/wr-pr-instructions.yml fails at its very first real step — Download artifact — with a 401 InvalidAuthenticationInfo from Azure blob storage. The step has almost certainly never run before: every run of this workflow since at least 2026-06-30 was skipped, because the upstream Add Pull Request Instructions workflow was failing on every PR with ReferenceError: module is not defined in ES module scope. When that ESM bug was fixed, four dependabot PRs produced the first upstream successes ever, this workflow woke up for the first time, and the download step failed on its debut run.

Action Items
  • Diagnose: confirmed the 401 originates from Azure (x-ms-error-code: InvalidAuthenticationInfo) on the SAS-signed redirect URL, not from GitHub. The artifact is valid — expired: false, and it downloads fine from outside the runner. Not expiry, not a missing artifact, not token scope, not the PR's dependency content
  • Confirm the dormant path: all 30 prior runs of wr-pr-instructions.yml show Last-Workflow-Success: skipped; the 17 recorded "successes" took the Last-Workflow-Failure branch and never executed the download
  • Replace the hand-rolled github.actions.downloadArtifact() octokit call with actions/download-artifact@v4 (run-id: ${{ github.event.workflow_run.id }} + github-token: ${{ secrets.GITHUB_TOKEN }}), which handles cross-run artifact auth on the runner's HTTP path
  • Update the following step to read artifact/artifact.txt (the new action writes into the path: you give it)
  • Stop indexing artifacts positionally — artifacts.data.artifacts[0] picks whichever artifact happens to be first. Match on name: adding-pr-instructions-artifact so a second artifact can never be downloaded by mistake
  • Re-open or comment on the 4 PRs that lost their instructions comment (#2223–#2228 range, dependabot PRs opened 2026-10-06T00:46Z) once the fix lands
  • Separately confirm the upstream ESM fix (require of a type: module script inside github-script) is intentionally landed and covered — it is the reason this workflow was dead for months

Acceptance criteria

  • A new PR opened against development results in a comment posted by Post Comment, with no 401 in the Download artifact step
  • Adding a second artifact to the upstream workflow does not change which artifact this workflow downloads
Resources/Instructions
  • Failing run: https://github.com/hackforla/VRMS/actions/runs/37395785437/job/112051281571
  • Failing step output:
    url: https://productionresultssa4.blob.core.windows.net/actions-results/.../adding-pr-instructions-artifact.zip?sig=...
    status: 401
    x-ms-error-code: InvalidAuthenticationInfo
    
  • Upstream workflow that had been failing: .github/workflows/pr-instructions.yml (ReferenceError: module is not defined in ES module scope)
Lingua principale
JavaScript
Stelle
62
Fork
105
Merge medio
2g 10h
PR unite (30g)
3

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di hackforla/VRMS

Tutte le issue di hackforla/VRMS

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.