Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Error during response serialization discards stack trace

Aperta
  • Qualcosa non va?
#3,091 0 commenti 1 reazione 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
65/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
grpc, nodejs, typescript
Ambito
api, backend, observability-sre

Direzione di ricerca

The issue points to the server-interceptors.ts file, lines 892-901, where errors in responseSerialize are caught and only the message is used. Start by examining that catch block and the surrounding server error handling. The goal is to modify the error handling to log the full error (including stack trace) or provide a callback for users. Run the provided reproduction with the helloworld example to see the current behavior, then test any changes by ensuring errors are properly logged or exposed.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Problem description

When an error occurs during response serialization, i.e., the responseSerialize callback of the MethodDefinition throws, this section of code extracts the error message and discards the rest of the error:
https://github.com/grpc/grpc-node/blob/92ac80f7857a2345ef3265f50741812b74cbdf0a/packages/grpc-js/src/server-interceptors.ts#L892-L901

Since this only ever surfaces as an INTERNAL error on the client side, the server operator has no indication in their logs that anything might be wrong until a client complains.
Additionally, even if reported by a client, the error message may be of limited use without a stack trace. In our case, I ended up needing to attach a debugger to the server process and put a breakpoint in the above catch block to log the error object incl. stack trace to the console.

I propose logging such errors or exposing some other mechanism, e.g., a callback, for library users to react to them. For example, we have integrated Sentry reporting for exactly scenarios like this, and were very confused why nothing showed up there.

Reproduction steps

Apply the following patch to the helloworld example in this repo:

diff --git a/examples/helloworld/static_codegen/greeter_server.js b/examples/helloworld/static_codegen/greeter_server.js
index ae2ab949..66df1e6a 100644
--- a/examples/helloworld/static_codegen/greeter_server.js
+++ b/examples/helloworld/static_codegen/greeter_server.js
@@ -36,6 +36,11 @@ function sayHello(call, callback) {
  */
 function main() {
   var server = new grpc.Server();
+
+  services.GreeterService.sayHello.responseSerialize = () => {
+    throw new Error("oops");
+  };
+
   server.addService(services.GreeterService, {sayHello: sayHello});
   server.bindAsync('0.0.0.0:50051', grpc.ServerCredentials.createInsecure(), (err, port) => {
     if (err != null) {

Then invoke the sayHello method any way you want.

Environment
  • OS name, version and architecture: Debian Bookworm AArch64
  • Node version: 24.18.1
  • Node installation method: Docker Hub library/node
  • Package name and version: @grpc/[email protected]
Additional context

No logs, which is the problem.

As for what led to this error: In our case, what happened was that bad data had ended up in a database row—a null in a PostgreSQL text[] column. This lead to generated serialization code attempting to call string(null) on a Writer object from protobufjs.

Lingua principale
TypeScript
Stelle
4.8k
Fork
720
Merge medio
2g 9h
PR unite (30g)
21

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di grpc/grpc-node

Tutte le issue di grpc/grpc-node

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.