Card a11y issues
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 15/100
- Tipo di issue
- Bug
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Ferma
- Stack tecnologico
- typescript
- Ambito
- accessibility, frontend
Direzione di ricerca
Start with the card components named in the issue: CardBase, BasicCard and BackgroundCard. Find where the card wraps its content in an <a> and where aria-labelledby and aria-describedby are set on that link. The issue offers three approaches without choosing one, so a maintainer decision is needed first. Done means the card's contents are reachable in sequence without an extra link wrapper, and the card title carries the link.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
During our a11y testing we have found out that the way cards provided by the library work is not the way they are expected to behave in relation to links.
The current implementation is flawed since when a card is supposed to be a clickable link it is wrapped in an <a> tag which makes sense for a typical user, but for a visually impaired person this adds an unnecessary wrapper before accessing the card's contents. This problem is amplified by the fact that this link wrapper currently also receives aria-labelledby and aria-describedby attributes from card's title and text respectively. This makes the card's description partially inaccessible as element's aria descriptions are not read out loud by default in some screen reader programs. Furthermore, adding a label to the link completely removes any indication that the user is in fact currently focusing on a card and not a simple link making the description even less accessible as there is no way for the user to know it's somewhere in there at all.
The way a card should work is allow the user to go through it's contents sequentially without any wrappers around them. If a card is a link then the link should be exposed to the user through the title element.
There are several ways to achieve this that may be suggested:
- Leaving the cards as they are now, but changing the element's aria roles in such a way that they behave as expected:
<a class="card" href="..." role="group">
<h1 class="title" role="link">Title</h1>
<div class="description">Description</div>
</a>
- Removing the link wrapper and creating a link overlay on top of the card:
<div class="card" style="position: relative;">
<a href="...">
<h1 class="title">Title</h1>
</a>
<div class="description">Description</div>
<a href="..." style="position: absolute; top: 0; right: 0; bottom: 0; left: 0;" aria-hidden="true"></a>
<div>
- Removing the link wrapper and adding a JavaScript redirect handler to the card element.
These changes would affect the BasicCard, BackgroundCard and potentially other components that use CardBase. It should also be noted that in any of the above solutions the card title's link should not be different from the link on the card itself.
I also suggest that images and icons inside cards should have aria-hidden applied to them by default unless they are provided an aria-label. Currently these images simply clutter the screen and provide nothing to the user
- Lingua principale
- TypeScript
- Stelle
- 65
- Fork
- 27
- Merge medio
- 5g 15m
- PR unite (30g)
- 15
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di gravity-ui/page-constructor
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 65/100
gravity-ui/page-constructor#1542 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 40/100
gravity-ui/page-constructor#1504 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 35/100
gravity-ui/page-constructor#1466 ·
I maintainer di solito rispondono entro 1 giorno
-
Yfm styles specificyApertagood first issue
Difficoltà 3/5 1-2 giorni Idoneità per principianti 35/100
gravity-ui/page-constructor#1389 · 1 reazione ·
I maintainer di solito rispondono entro 1 giorno
-
Vite playgroundApertahelp wanted
Difficoltà 3/5 1-2 giorni Idoneità per principianti 30/100
gravity-ui/page-constructor#1388 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di gravity-ui/page-constructor
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
software-mansion/argent#1946 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 63/100
podman-desktop/podman-desktop#20216 ·
I maintainer di solito rispondono entro 1 giorno
-
[Type] Bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
WordPress/ai#1386 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
I maintainer di solito rispondono entro 5 giorni
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
omdsh-dev/DSH-better-sidebar#1205 ·
I maintainer di solito rispondono entro 3 giorni