Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

live.connect() (Vertex AI) resolves ADC and refreshes the OAuth token synchronously on the event loop on every connect

Aperta
  • Qualcosa non va?
#3,056 2 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@Venkaiahbabuneelam ci sta già lavorando.

Dal 6/10/2026.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
74/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
google-cloud, python
Ambito
authentication, backend-api-design, performance

Direzione di ricerca

Start in google/genai/live.py at AsyncLive.connect() and compare its Vertex AI authentication path with _api_client._async_access_token() and async_get_token_from_credentials(). Check the existing Live and auth tests before making a change. Done means ADC is cached per client, refresh work happens off the event loop, and the reported connect-time stalls and repeated refreshes are covered by tests.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

priority: p2 type: bug
Environment
  • google-genai 2.24.0, google-auth 2.58.0, Python 3.12
  • Vertex AI backend (GOOGLE_GENAI_USE_VERTEXAI=true), service-account ADC
  • Live API with many concurrent sessions per process (telephony voice agent)
What happens

On Vertex, AsyncLive.connect() (google/genai/live.py, ~L1055-1069) runs this before it opens the websocket:

if not self._api_client._credentials:
    creds, _ = google.auth.default(scopes=[...])   # sync, on the event loop
else:
    creds = self._api_client._credentials
if not (creds.token and creds.valid):
    auth_req = _auth_requests().Request()
    creds.refresh(auth_req)                         # sync HTTP, on the event loop

Two problems:

  1. Blocking I/O inside an async API. creds.refresh() makes a synchronous requests call to the token endpoint, on the event loop. Every other coroutine in the process stalls until it returns. For us that is live audio for every other call on the pod.
  2. No caching when the client was built without credentials=. The resolved credentials are a local variable and are never stored on _api_client. Every connect() therefore runs google.auth.default() again and refreshes a fresh, token-less credentials object. The sync refresh runs on every connect, not once an hour.

The async REST path already handles both. _api_client._async_access_token() loads auth via asyncio.to_thread(load_auth, ...) under an async lock and caches it in self._credentials. async_get_token_from_credentials() refreshes via asyncio.to_thread(refresh_auth, ...), only when expired.

Repro
import asyncio, time
from google import genai

async def ticker(stop, worst):
    while not stop.is_set():
        t = time.perf_counter(); await asyncio.sleep(0.01)
        worst[0] = max(worst[0], (time.perf_counter() - t - 0.01) * 1000)

async def main():
    client = genai.Client()  # Vertex via env, no credentials= passed
    for i in range(3):
        stop, worst = asyncio.Event(), [0.0]
        tk = asyncio.create_task(ticker(stop, worst))
        await asyncio.sleep(0.05)  # let the ticker start before connect() blocks
        async with client.aio.live.connect(
            model="gemini-live-2.5-flash-native-audio",
            config={"response_modalities": ["AUDIO"]},
        ):
            pass
        stop.set(); await tk
        print(f"connect #{i+1}: max event-loop stall {worst[0]:.0f} ms")
    await client.aio.aclose()

asyncio.run(main())

Output (Vertex, us-central1). I also counted service_account.Credentials.refresh calls:

connect #1: max event-loop stall 517 ms, token refreshes during connect: 1
connect #2: max event-loop stall 410 ms, token refreshes during connect: 1
connect #3: max event-loop stall 415 ms, token refreshes during connect: 1

Expected: auth resolved once per client, refresh only near expiry, and never on the event loop. Stalls should be a few ms.

Suggested fix

In AsyncLive.connect(), reuse the async REST path: await self._api_client._async_access_token(). That loads ADC off-loop, caches it on the client, and refreshes off-loop under the async auth lock. At minimum, store the resolved credentials on _api_client and wrap google.auth.default() and creds.refresh() in asyncio.to_thread.

Workaround

We build one genai.Client(credentials=creds) per process, in a thread. We keep creds FRESH by calling creds.refresh() via asyncio.to_thread whenever creds.token_state is not TokenState.FRESH. valid turns False at the same REFRESH_THRESHOLD, so connect() never takes the sync branch. With the same ticker, max stall per connect drops to 9–28 ms.

Lingua principale
Python
Stelle
4k
Fork
1k
Merge medio
1g 17h
PR unite (30g)
54

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di googleapis/python-genai

Tutte le issue di googleapis/python-genai

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.