[self-care:reactive-ui] Correct reactive-ui skill guidance for named UI element declarations

Chiusa
  • Qualcosa non va?
#19,483 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
1/5
Tempo stimato
Meno di un'ora
Idoneità per principianti
1/100
Tipo di issue
Documentazione
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
javascript
Ambito
documentation

Direzione di ricerca

The issue describes correcting .github/skills/reactive-ui/SKILL.md and cites dashboard/site/src/specification.js and src/validator-views.js as evidence. Start by reviewing the skill guidance against VIEW_KEYS and the view validator. The issue says the guidance has already been pushed to a branch and provides a pull request creation link, so this work is already underway.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

agentic-workflows self-care self-care:reactive-ui-expert

[!TIP]
Your pull request is ready to create! 🎉 ✅

Everything is OK—the changes have been pushed to a branch. Please review the protected files, then create the pull request when you are ready.

Create the pull request

The original pull request description is below.

The reactive-ui skill told authors to give a named UI element a concise intent. Current source contradicts this: VIEW_KEYS in dashboard/site/src/specification.js has no intent key (only pages and table row actions do). Views declare subject, objective and acceptance, with sources under data.sources. The skill now says this. No JavaScript or dashboard document changed, and reactive and DOM ownership guidance is unchanged.

No eligible pure-JSON view-source migration was found. The only remaining data-shaping JavaScript (simulation-days, evidence row normalization, callout visibility) is a synthetic or ingestion adapter, not a view-specific projection that canonical entities can replace in dashboard.queries. Recent changes (e.g. card-list-pagination.js) already use state, effect, abort-scoped lifetimes and createFactoryScope.

Evidence: dashboard/site/src/specification.js (VIEW_KEYS, BUILT_IN_PAGE_KEYS), src/validator-views.js, .github/skills/reactive-ui/SKILL.md.

Validation: documentation-only change to a skill file; no tests apply.

Control Plane

[!NOTE]
Protected files

This patch modifies protected files, which may affect project dependencies, CI/CD pipelines, or agent behaviour.

Protected files

To route changes like this to a review issue instead of blocking, configure protected-files: fallback-to-issue in your workflow configuration.

Generated by SelfCare / Reactive UI Expert · copilot · auto · 53.6 AIC · ⌖ 0.929 AIC · ⊞ 15.6K · ◷

  • expires on Oct 29, 2026, 12:38 PM UTC
Lingua principale
JavaScript
Stelle
8
Fork
5
Merge medio
2h 50m
PR unite (30g)
815

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di githubnext/gh-cao

Tutte le issue di githubnext/gh-cao

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.