Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

[Bug]: Preset-overridden skill hashes are not synchronized in integration manifest during integration upgrade

Aperta
#4,696 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
65/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python
Ambito
cli, tooling

Direzione di ricerca

The bug is in src/specify_cli/integrations/command_upgrade.py. Start by reading the _register_presets_for_agent function and how it interacts with new_manifest. Look at PresetManager.register_enabled_presets_for_agent to see how it writes skill files. After preset registration, you need to update new_manifest with the new file hashes for preset-overridden skills. Check how manifest.record_existing works. A test can be run by reproducing the steps in the bug description and verifying specify integration status reports OK after the fix.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

triage-nice-to-have
Bug Description

When an enabled preset overrides a core command that is rendered as an agent skill (such as for codex in .agents/skills/<name>/SKILL.md), running specify integration upgrade <agent> --force succeeds, but the integration manifest .specify/integrations/<agent>.manifest.json retains the hash of the base/default template.

Because command_upgrade.py invokes new_manifest.save() before calling _register_presets_for_agent(), the preset's re-registration overwrites the skill file on disk with the preset content without updating the manifest.

As a result:

  1. specify integration status immediately reports the skill file as modified with finding manifest-file-modified.
  2. Any subsequent specify integration upgrade <agent> (without --force) is blocked by check_modified().
Steps to Reproduce
  1. Initialize a new project with an agent integration that uses skills (e.g., codex):

    specify init --here --integration codex
    specify integration status
    # Status: OK (0 modified, 0 missing)
    
  2. Add a local preset that wraps or overrides a core command (e.g. speckit.tasks or speckit.specify):
    Create test-preset/preset.yml:

    schema_version: "1.0"
    preset:
      id: "test-task-preset"
      name: "Test Task Preset"
      version: "1.0.0"
      description: "Test preset overriding speckit.tasks"
    requires:
      speckit_version: ">=0.1.0"
    provides:
      templates:
        - type: "command"
          name: "speckit.tasks"
          file: "commands/speckit.tasks.md"
          strategy: "wrap"
    

    Install the preset:

    specify preset add --dev ./test-preset
    
  3. Upgrade the integration with --force:

    specify integration upgrade codex --force
    

    Output reports: ✓ Integration 'Codex' upgraded successfully.

  4. Check integration status:

    specify integration status
    
Expected Behavior

specify integration upgrade codex --force should re-baseline or synchronize the hashes of skills written by active presets into .specify/integrations/codex.manifest.json.
After upgrade completes, specify integration status should report OK with 0 modified managed files.

Actual Behavior

specify integration status reports Modified managed files: 1 and status WARNING:

  • Finding: manifest-file-modified (codex): .agents/skills/speckit-tasks/SKILL.md was modified after installation.

Subsequent specify integration upgrade codex without --force fails with:
1 file(s) have been modified since installation... Use --force to overwrite modified files.

Specify CLI Version

1.0.10

AI Agent

Codex CLI

Operating System

macOS (Darwin arm64)

Python Version

Python 3.12

Error Logs
$ specify integration status
Integration status: WARNING
Default integration: codex
Installed integrations: codex
Multi-install safe: yes
Shared templates target alignment: none
Modified managed files: 1
Missing managed files: 0
Invalid manifest paths: 0
Unchecked manifests: 0

Findings:
- warning manifest-file-modified (codex): .agents/skills/speckit-tasks/SKILL.md was modified after installation.
  Suggestion: Run `specify integration upgrade codex` or reinstall the integration.
Additional Context
Root Cause Analysis

In src/specify_cli/integrations/command_upgrade.py:

    # Phase 1: Setup writes default skills and records their hashes
    integration.setup(
        project_root,
        new_manifest,
        ...
    )
    ...
    # Manifest is saved to disk with base skill hashes
    new_manifest.save()
    _write_integration_json(project_root, installed_key, installed_keys, settings)

    ...

    # Phase 2: Presets are re-registered AFTER manifest was saved!
    if key == installed_key:
        _register_extensions_for_agent(...)
        _register_presets_for_agent(
            project_root,
            key,
            continuing="The integration was upgraded, but installed presets may need re-registration.",
        )

_register_presets_for_agent() calls PresetManager.register_enabled_presets_for_agent(agent_key).
This regenerates and writes the preset-overridden content to .agents/skills/<name>/SKILL.md (with frontmatter source: "preset:<preset_id>").
However, new_manifest is never updated with these newly written preset file hashes.

Suggested Fix Shape

After _register_presets_for_agent() completes, if any preset was registered, inspect skills tracked in both the preset registry and new_manifest. When a skill file on disk has matching provenance (e.g. source == f"preset:{preset_id}"), update new_manifest.record_existing(relative) and save new_manifest.

This ensures that legitimate preset overrides are recognized as the clean baseline, while preserving tamper detection for manual edits.

AI Disclosure

AI assistance (Antigravity) supervised by human maintainer was used to trace the execution path in command_upgrade.py and draft this bug report. All code paths and CLI behaviors were verified against a clean reproduction environment.

Lingua principale
Python
Stelle
138k
Fork
12.4k
Merge medio
3g 2h
PR unite (30g)
169

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di github/spec-kit

Tutte le issue di github/spec-kit

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.