gh stack link --remote <fork> queries the fork’s parent repository

Aperta
#496 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
68/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
git, github, go

Direzione di ricerca

Inizia riproducendo gh stack link --base main --remote fork --open <first-pr> <second-pr> nella configurazione fork multi-remote, quindi esamina la risoluzione del repository e lo stato di .git/gh-stack. Il lavoro è completato quando il comando usa l'endpoint del fork e i segnali di repository in conflitto falliscono prima di una richiesta API con un errore di selezione chiaro; aggiungi un test di regressione per questo scenario.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Summary

In a fork clone with separate upstream and fork remotes, gh stack link --remote fork queries the stack API for the upstream parent repository instead of the selected fork.

This prevents linking existing PRs when access to the parent is restricted, even though the authenticated user can access the fork and all PRs being linked have both their base and head repositories in the fork.

This appears related to #381, but that report covers gh stack submit selecting origin in a multi-remote clone. This reproduction covers gh stack link, has no origin remote, and shows the extension selecting a fork's parent despite an explicit --remote, remote.pushDefault, and gh-resolved repository.

Environment

  • gh version 2.100.0 (2026-09-03)
  • gh stack / github/gh-stack v0.1.1
  • Repository: <fork-owner>/<repository>, a fork of <upstream-owner>/<repository>
  • Two existing PRs whose base and head repositories are both the fork

Repository configuration

$ git remote -v
fork        git@github.com:<fork-owner>/<repository>.git (fetch)
fork        git@github.com:<fork-owner>/<repository>.git (push)
upstream    git@github.com:<upstream-owner>/<repository>.git (fetch)
upstream    no_push (push)

$ git config --get remote.pushDefault
fork

$ git config --get remote.fork.gh-resolved
<fork-owner>/<repository>

$ gh repo set-default --view
<fork-owner>/<repository>

The local .git/gh-stack state was initialized with the parent repository despite this configuration:

{
  "schemaVersion": 1,
  "repository": "github.com:<upstream-owner>/<repository>"
}

Steps to reproduce

  1. Clone a GitHub fork with one remote for the fork and a separate fetch-only remote for its parent. There is no origin remote.

  2. Set the fork as the push/default GitHub repository:

    git config remote.pushDefault fork
    git config remote.fork.gh-resolved <fork-owner>/<repository>
    
  3. In the fork, create two open PRs intended to form a stack. Both PRs have base and head repositories equal to <fork-owner>/<repository>.

  4. Run:

    gh stack link --base main --remote fork --open <first-pr> <second-pr>
    

Actual behavior

The extension calls the parent repository's stack endpoint and fails:

Checking existing stacks...
failed to list stacks: HTTP 403
(https://api.github.com/repos/<upstream-owner>/<repository>/stacks?per_page=100&page=1)

The authentication failure is expected for that parent repository. The unexpected behavior is querying the parent at all.

Expected behavior

gh stack link --remote fork should query and mutate stack metadata in <fork-owner>/<repository>, matching:

  • the explicitly selected remote;
  • remote.pushDefault;
  • standard gh repository resolution; and
  • the base/head repository of every PR passed to --open.

If these signals disagree, the extension should fail before making an API request and report which repository needs to be selected.

Controls

The correct fork endpoint is accessible with the same authentication:

gh api 'repos/<fork-owner>/<repository>/stacks?per_page=100&page=1'
# HTTP 200

Running the same link command from a temporary Git repository whose only remote is <fork-owner>/<repository> succeeds:

Created stack with 2 PRs

This isolates the failure to repository resolution in the multi-remote fork clone rather than authentication, PR shape, or stack creation.

Impact

  • gh stack link cannot be used normally in this fork/multi-remote layout.
  • Users may receive misleading authentication errors for a repository they did not select.
  • Where the user has access to both repositories, the command may read or write stack metadata in the wrong repository.

Workaround

Run gh stack link from a temporary repository configured with only the fork remote. This is error-prone and loses the normal relationship with the working clone.

Related

  • #381 reports the likely shared repository-resolution defect for gh stack submit.
  • #461 reports stale fork/parent metadata affecting gh stack submit after a remote rename.

If maintainers consider link covered by #381, I am happy for this to be closed as a duplicate; the additional reproduction may still be useful for a regression test.

Lingua principale
Go
Stelle
1.5k
Fork
73
Merge medio
1g 8h
PR unite (30g)
7

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di github/gh-stack

Tutte le issue di github/gh-stack

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.