Search explanations describe parts the search didn't run

Aperta
  • Qualcosa non va?
#2,147 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
57/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
backend-api-design

Direzione di ricerca

Start with the time-series agent output in agent.ts:53-72, then follow how search.ts:910-948 builds the executed request and how structured.ts:462-469 and formatters.ts:209-210 return the explanation. Compare the explanation with the request that actually ran, including fields and time range; done means callers are not given an explanation that claims omitted search parts were executed.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

includeExplanation on search_errors and the other runSearchEvents tools returns the embedded agent's own explanation text unchanged. It can describe grouping, fields, or a time range that the executed request does not contain, so callers trust results that don't match what they asked for.

Reported in Sentry MCP user feedback (MCP-SERVER-GN4) from an automated caller:

  • Grouped time series: an hourly series asked for grouping by project plus distinct users. The explanation said both were returned. executedSearch.fields was only count(), and the output was one ungrouped series. The span for that call was not sampled, so this case is from the feedback text only.
  • Time range: the explanation described a fixed window while executedSearch.timeRange was statsPeriod with null start/end. This one is verified in a trace and fixed in #2146.

What the code does (main @ 737f183):

  • The agent's time-series output is one yAxis plus interval, with no group-by or top-N field (agent.ts:53-72). The handler sends one yAxis to events-timeseries (search.ts:1083-1104) and reports fields: [yAxis] (structured.ts:469). Any grouping or second aggregate the agent planned is dropped without a note.
  • explanation is set from parsed.explanation (search.ts:932) and passed through unchanged (structured.ts:462-465, formatters.ts:209-210). The handler later overrides the time range, fields, sort, or query (search.ts:910-948), but never compares the explanation with what ran.

Related: #2017 adds explicit multi-axis series for traces, logs, and metrics, not errors and not grouped series. #2139 and #2146 fix time-range drops, not the explanation text.

via Sentry.

--

View Session [Sentry]

Lingua principale
TypeScript
Stelle
961
Fork
179
Merge medio
15h 33m
PR unite (30g)
476

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di getsentry/toolkit

Tutte le issue di getsentry/toolkit

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.