Plan SDK-owned migrations for all Sentry SDK upgrades
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 25/100
- Tipo di issue
- Funzionalità
- Chiarezza
- Da chiarire
- Stato di attività
- Attiva
- Stack tecnologico
- github, javascript, node.js, typescript
- Ambito
- backend-api-design, cli, devtools
Direzione di ricerca
Start by reading lib/init/wizard-runner.ts and the sentry-wizard workflow, then review the migration engine described in getsentry/cli#1499 and the related upgrade idea in #1483. The issue is a broad plan with open questions about the migration contract, artifact index, and execution across languages; it does not identify a bounded implementation task or a completion test.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Upgrading across an SDK major still means reading the migration guide and fixing renamed options, moved imports, and removed exports by hand. getsentry/cli#1499 (by @msonnb) prototyped sentry migrate with a JS v10 → v11 codemod. That PR is closing with the getsentry/cli archive, and its review set a different direction. This issue records that direction as the plan for SDK upgrades in general. #1483 tracks the user-facing sentry sdk upgrade idea.
Design direction (from BYK's review of cli#1499)
- The CLI is the harness, not the place where migrations live. It provides the runtime: detection, dry-run, safety checks, task execution, and reporting. Migration logic for each SDK lives in that SDK's repo, so the SDK team owns it.
- Migrations load at runtime, not inside the binary. The CLI can't ship every migration for every SDK all the time, so it fetches or imports the migration for the detected SDK and version when it needs it.
- Use the same backend as
sentry init. Upgrades should run through the server-driven workflow thatsentry inituses (lib/init/wizard-runner.ts,sentry-wizardworkflow), with local tools doing the file work. @betegon owns this direction. - Fall back to a generic path (suggested by @HazAT). When no dedicated migration exists, detect the SDK and version range, read the changelog or migration guide for that range, and list the breaking changes for an agent to act on.
Plan
- Detection. Find the installed SDK(s) and version(s) in the project, reusing
sentry init's platform and project detection. Get the target version from the release registry. - Migration contract. Define what an SDK-published migration looks like, based on the engine in cli#1499:
- A list of small tasks with stable ids. Each task checks whether it applies and makes no change when it doesn't.
- Deterministic edits are applied directly. Call sites that need a human decision get a
TODO. - A failing task doesn't stop the run.
--only/--skipselect tasks by id. - Output includes a report of what's left with
file:lineper item, which can be handed to an agent.
- Distribution. SDK repos publish migrations as versioned artifacts, listed in the release registry or a similar central index. The CLI downloads and caches them on demand. Nothing is embedded at build time.
- Harness behavior in the CLI. Carry over the safety rules from cli#1499:
- Require git and a clean tree (
--allow-dirtyto override). - Support
--dry-run. - Rewrite manifests (for example
package.json) without installing anything. - Make re-runs safe.
- Require git and a clean tree (
- Agent handoff. Leftover items from a migration and the output of the generic fallback go to the init backend or an agent through the same channel, so both paths produce one result format.
- Command surface. Combine with #1483 into one entry point (for example
sentry sdk upgrade [--to <version>] [--dry-run]) instead of a separatemigratecommand.
Rollout
- Phase 0: Agree on the migration contract, the distribution and index format, and how it connects to the init backend. Owners: SDK teams, @betegon.
- Phase 1: Build the harness and the generic changelog/migration-guide fallback. This covers every SDK without a dedicated migration.
- Phase 2: Move the JS v10 → v11 migration from cli#1499 into
getsentry/sentry-javascriptas the first SDK-owned migration, and run it through the harness. - Phase 3: Write a guide for SDK teams on adding migrations for their next majors.
Open questions
- Where does the migration index live: the release registry, or a new endpoint?
- How do migrations run outside JS? For example, a sandboxed JS runtime in the CLI that runs codemods for any language, or server-side execution through the init backend.
- How should ambiguous edits that can't be made deterministically be split between local codemods and agent-assisted steps?
Related: #1483, #1468, getsentry/cli#1499
via BYK.
--
- Lingua principale
- TypeScript
- Stelle
- 938
- Fork
- 166
- Merge medio
- 1g 5h
- PR unite (30g)
- 172
Preparare l'ambiente
Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di getsentry/toolkit
-
bug MCP
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
getsentry/toolkit#1621 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
bug MCP
Difficoltà 2/5 1-3 ore Idoneità per principianti 73/100
getsentry/toolkit#1618 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
getsentry/toolkit#1471 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 25/100
getsentry/toolkit#1632 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
getsentry/toolkit#1623 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di getsentry/toolkit
Issue simili
-
DRY stats column groupingsApertaready
Difficoltà 2/5 1-3 ore Idoneità per principianti 63/100
wheresrhys/totf#1214 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
CodeChefVIT/ffcs#281 ·
I maintainer di solito rispondono entro 2 giorni
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 83/100
endora-commerce/endora-commerce#451 ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
vetro-protocol/vetro-monorepo#1007 ·
I maintainer di solito rispondono entro 1 giorno