v12: Remove the deprecated `withSentry` root export from `@sentry/solidstart`

Aperta
#25,915 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Refactoring
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
javascript, rollup, typescript, vite

Direzione di ricerca

Start at the @sentry/solidstart root entry and trace its withSentry export to identify the build-time types and runtime dependency path. Check the server runtime entry for imports of @sentry/bundler-plugins and the orchestrion Rollup transform. Update MIGRATION.md and the SolidStart guide at docs/platforms/javascript/guides/solidstart/index.mdx; done means the root export is removed, the documented import uses @sentry/solidstart/vite, and the runtime no longer pulls in build tooling.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

javascript

Problem

withSentry wraps the SolidStart config at build time. The root entry of @sentry/solidstart re-exports it. Because of this, the server runtime entry reaches @sentry/bundler-plugins and the orchestrion rollup transform. Any tool that traces or bundles the server entry then pulls in that build-time tooling.

getsentry/sentry-javascript#25725 adds withSentry to @sentry/solidstart/vite, next to the Vite plugin. The root export stays, deprecated, so existing app.config.ts files keep working until the next major version.

Proposal

In v12, remove withSentry (and its related build-time types) from the root entry of @sentry/solidstart. Users must import it from @sentry/solidstart/vite.

// before
import { withSentry } from "@sentry/solidstart";

// after
import { withSentry } from "@sentry/solidstart/vite";

Tasks

  • Remove the withSentry re-export from the root entry.
  • Confirm that the server runtime entry no longer imports @sentry/bundler-plugins or the orchestrion rollup transform.
  • Add the change to the v11 to v12 migration guide (sentry-javascript MIGRATION.md and sentry-docs).
  • In sentry-docs, remove the Alert in docs/platforms/javascript/guides/solidstart/index.mdxthat explains the old import path.

References

  • getsentry/sentry-javascript#25725
  • #25676
  • getsentry/sentry-javascript#25676
Lingua principale
TypeScript
Stelle
8.8k
Fork
1.9k
Merge medio
1g 21h
PR unite (30g)
617

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di getsentry/sentry-javascript

Tutte le issue di getsentry/sentry-javascript

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.