Own turn lifecycle in durable-queue tests

Aperta
  • Qualcosa non va?
#1,398 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
35/100
Tipo di issue
Refactoring
Chiarezza
Abbastanza chiara
Stato di attività
Ferma
Stack tecnologico
redis, sql, typescript
Ambito
backend, databases, distributed-systems, testing-qa

Direzione di ricerca

Inizia da packages/junior/tests/integration/durable-queue.test.ts e leggi anche packages/junior/src/chat/task-execution/README.md e policies/testing.md. Esegui gli integration test esistenti di durable-queue, quindi copri gli outcome live Slack-to-worker elencati, senza inizializzare checkpoint né sostituire componenti runtime gestiti da Junior; il lavoro è completo quando vengono verificati lo stato terminale, la cronologia SQL, le risposte e le menzioni successive.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Turn lifecycle coverage is split across durable-queue, agent-continue-slack, heartbeat, and large component suites. Several “integration” cases seed Redis/SQL or replace the agent runner, so they miss path bugs (accept-then-timeout, multi-slice continue).

packages/junior/tests/integration/durable-queue.test.ts should own the product outcomes below. Drive live Slack ingress → worker → real agent. Fake only the model stream and Slack HTTP. Assert user-visible replies, turn terminal state, SQL history, and that a later mention still works.

Product outcomes

Outcome User-visible result Live drive
Happy path One mention → one reply → turn completed → mailbox empty Mention → run
Long turn survives host limit Deadline mid-work parks at a safe boundary; fresh wake finishes with one final reply; history kept Model does tool work, spend deadline, next queue wake finishes
Accepted reply is terminal After Slack accepts a tool-free reply, turn completes once; no second post; assistant stays in SQL Hold chat.postMessage past deadline (and/or lose lease after accept)
Worker dies mid-run (no accept) Turn fails once; committed history kept; next mention works Start run, expire lease before accept
Transient agent failure Fail before input commit → retry, no Slack post; retry limit → at most one fallback Throw before commit / until limit
Mid-turn steer Second @ mention folds into the same turn; still one final reply Hold active run, second mention, release

Every terminal case must leave the conversation able to take a new user mention.

Harness rules

  • Start from webhook ingress or a real queue wake after a live park. Do not seed turn checkpoints for these product contracts once the live path can create the state.
  • Do not replace Junior-owned runtime, resume, checkpoint, worker, lease, mailbox, or queue routing.
  • Custom agentRunner only for edges the model stream cannot express (e.g. throw before input commit). Prefer stream + real durability otherwise.
  • Disrupt from outside: hold Slack HTTP, spend the host deadline, expire the lease, send a second mention.

Out of scope here

  • Reply chunking / fallback copy → finalized-reply-behavior
  • Cross-actor steer policy → conversation-turn-steering-behavior
  • OAuth link UX / credential copy → oauth-resume-slack
  • Heartbeat only enqueueing a wake for stale paused rows → heartbeat
  • Cursor schema / append-only history rules → component tests

Current gaps (as of #1397)

  • Have live: happy path; accept during deadline (first slice); retry / retry-limit; steer (agent hold).
  • Missing live spine: long turn that times out mid-work, parks, resumes on a fresh wake, and finishes (production multi-slice shape).
  • Still seeded: lease loss after accept; worker disappear mid-run; timeout-pause “leave host request.”
  • Owned elsewhere / weak here: auth park+resume.

Related

Requested by David Cramer.

--

View Junior Session [Sentry]

Lingua principale
TypeScript
Stelle
397
Fork
43
Merge medio
7h 42m
PR unite (30g)
650

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di getsentry/junior

Tutte le issue di getsentry/junior

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.