intermittent test failures: web-forms e2e: firefox visuals

Aperta
#958 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
Mezza giornata
Idoneità per principianti
54/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
playwright, typescript
Ambito
testing

Direzione di ricerca

Start with the failing visual test at e2e/test-cases/visual/all-question-types.test.ts:68 and the linked GitHub Actions run to inspect the Firefox screenshot mismatch for select-map-zoom-out.png. Check the screenshot helper at e2e/screenshot.ts:102 and the map control at e2e/page-objects/controls/MapControl.ts:216. Done means identifying and fixing the intermittent failures so the affected Firefox visual tests pass reliably.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

https://github.com/getodk/central-frontend/actions/runs/43368646506/job/131701057077?pr=1990

Running 21 tests using 1 worker
··××F××F·········×±×±······

  1) [visual-firefox] › e2e/test-cases/visual/all-question-types.test.ts:68:5 › All Question Types (Visual) › Select one from map › zooms in and out, pans the map and zooms to fit all features 

    Error: expect(page).toHaveScreenshot(expected) failed

      30275 pixels (ratio 0.08 of all image pixels) are different.

      Snapshot: select-map-zoom-out.png

    Call log:
      - Expect "toHaveScreenshot(select-map-zoom-out.png)" with timeout 5000ms
        - verifying given screenshot expectation
      - taking page screenshot
        - disabled all CSS animations
      - waiting for fonts to load...
      - fonts loaded
      - 30275 pixels (ratio 0.08 of all image pixels) are different.
      - waiting 100ms before taking screenshot
      - taking page screenshot
        - disabled all CSS animations
      - waiting for fonts to load...
      - fonts loaded
      - captured a stable screenshot
      - 30275 pixels (ratio 0.08 of all image pixels) are different.


       at screenshot.ts:102

      100 |   const box = await getBox(locator, screenshotName);
      101 |
    > 102 |   await expect(page).toHaveScreenshot(screenshotName, {
          |                      ^
      103 |     fullPage: isFullPage,
      104 |     clip: {
      105 |       x: Math.round(box.x + scroll.x),
        at expectScreenshot (/__w/central-frontend/central-frontend/packages/web-forms/e2e/screenshot.ts:102:22)
        at MapControl.expectMapScreenshot (/__w/central-frontend/central-frontend/packages/web-forms/e2e/page-objects/controls/MapControl.ts:216:5)
        at /__w/central-frontend/central-frontend/packages/web-forms/e2e/test-cases/visual/all-question-types.test.ts:70:7

    attachment getodk/central#1: select-map-zoom-out (image/png) ─────────────────────────────────────────────────
    Expected: e2e/test-cases/visual/all-question-types.test.ts-snapshots/select-map-zoom-out-firefox.png
    Received: test-results/test-cases-visual-all-ques-481b5-d-zooms-to-fit-all-features-visual-firefox/select-map-zoom-out-actual.png
    Diff:     test-results/test-cases-visual-all-ques-481b5-d-zooms-to-fit-all-features-visual-firefox/select-map-zoom-out-diff.png
    Error Context: test-results/test-cases-visual-image-la-f28e5-cked-columns-and-no-buttons-visual-firefox/error-context.md

  2 failed
    [visual-firefox] › e2e/test-cases/visual/all-question-types.test.ts:68:5 › All Question Types (Visual) › Select one from map › zooms in and out, pans the map and zooms to fit all features 
    [visual-firefox] › e2e/test-cases/visual/all-question-types.test.ts:82:5 › All Question Types (Visual) › Select one from map › opens details of saved feature and remove saved feature 
  2 flaky
    [visual-firefox] › e2e/test-cases/visual/image-labels.test.ts:53:5 › Image Selects (Visual) › Select with images › select one with fixed column count 
    [visual-firefox] › e2e/test-cases/visual/image-labels.test.ts:66:5 › Image Selects (Visual) › Select with images › select one with packed columns and no buttons 
  17 passed (2.8m)
Error: Process completed with exit code 1.

Lingua principale
TypeScript
Stelle
38
Fork
24
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

  • Nessun Dockerfile né file Docker Compose
  • Ha un modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di getodk/web-forms

Tutte le issue di getodk/web-forms

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.