Enforce required human review when protected paths are modified

Aperta
  • Qualcosa non va?
#37 4 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
25/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Tranquilla
Stack tecnologico
github
Ambito
security

Direzione di ricerca

The relevant files are the repository's CODEOWNERS file, which currently assigns * @fullsend-ai/core, and the main branch protection settings in GitHub's repository settings. PR #36 is the example to read for how the protected-path warning appeared and was bypassed. The change is done when a PR that modifies AGENTS.md cannot merge without an approval from a code owner who is not its author. The payload does not say whether self-merge is intentional, so confirm that with maintainers before changing settings.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement ready-for-triage triaged

What happened

On PR #36, the fullsend-ai review agent correctly identified that AGENTS.md was modified and flagged it as a protected path, stating it could not approve and that human review was required. The CODEOWNERS file assigns @fullsend-ai/core as owner of all paths (* @fullsend-ai/core). Despite this, the PR was self-merged by the author without any recorded human review approval. The review agent's second run (commit 05bd450e) explicitly noted: 'Protected paths detected: AGENTS.md modified — review agent cannot approve; human reviewer must approve.'

What could go better

The review agent's protected-path detection is advisory only — it posts a comment but cannot block merge. GitHub branch protection rules apparently do not enforce CODEOWNERS review on this repo, or the author's membership in @fullsend-ai/core allows self-approval. AGENTS.md controls agent behavior instructions for the entire repository; changes to it should require human oversight from someone other than the author. Without enforcement, the review agent's warning is easy to overlook or bypass. Confidence: high that enforcement is missing, moderate uncertainty about whether this is intentional (small team may prefer velocity over ceremony).

Proposed change

Enable the 'Require review from Code Owners' setting in the main branch protection rules on GitHub. Additionally, consider adding explicit CODEOWNERS entries for sensitive files to make protection visible: AGENTS.md @fullsend-ai/core and CODEOWNERS @fullsend-ai/core. If self-merge is intentional for velocity, at minimum add a CI check that warns (or fails) when AGENTS.md is modified without a review from someone other than the PR author.

Validation criteria

After enabling the branch protection setting, attempt to merge a PR that modifies AGENTS.md without a CODEOWNERS-approved review from a non-author. GitHub should block the merge. Verify on the next 3 PRs that touch AGENTS.md or CODEOWNERS that a human review is required before merge.

Generated by retro agent from https://github.com/fullsend-ai/experiments/pull/36

Lingua principale
Python
Stelle
1
Fork
9
Merge medio
1g 13h
PR unite (30g)
7

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di fullsend-ai/experiments

Tutte le issue di fullsend-ai/experiments

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.