[2.0 bug] different/incorrect behaviour due to bump [email protected] up to @fresh/core@^2.0.0-alpha.29

Aperta
#2,850 5 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Ferma
Stack tecnologico
deno, typescript
Ambito
frontend

Direzione di ricerca

Start with the linked login.tsx reproduction and compare how Fresh v1 and v2 render the second form after the handler returns. Trace how input values are preserved across that route transition, then add a regression test for distinct forms with autocomplete="off" and defaultValue="". Done means the second form starts empty in v2; the issue reports no framework file or test to begin from.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

i have a partial route login.tsx, it renders a different form depending on what data the handler returns. theres an input field in each form, and theyre pretty much in identical shape except for having different id, name, placeholder etc. what the partial route does is first it asks for email, after user enters email, it then email a code to the user and displays the another form that asks for the code which user would get from their email, user then submit the code, then they get a session in the cookie.

the form looks like this

<form method="POST" autocomplete="off" id="email-form" class="mt-2">
    <input
      class="focus:outline-1 focus:outline-yellow-300"
      type="email"
      id="email-address"
      name="email"
      placeholder=" enter email"
      autocomplete="off"
      autoFocus
      defaultValue=""
      required
    />
    <input
      type="submit"
      value="send code"
      class="px-3 bg-yellow-300 cursor-pointer rounded-sm hover:bg-lime-200"
    />
</form>

w/ v1.7.3, when the second form(same as above just having different id, name etc) is displayed, the input field is empty which is as expected (see vid below), as u can see ive explicitly added autocomplete="off" and defaultValue="" attributes.

w/ fresh v2, when the second form is displayed, the input field is pre-filled w the email address user entered in the email form (see vid below), which is an unexpected and unwanted behaviour change, and i think its incorrect given the form and input has different id and name, and autocomplete="off", defaultValue="" attributes. And the behaviour completely confuses the user as they cant see the placeholder at all, its hard to notice this is another form, and they have to delete the email address for them to be able to enter the code and submit it. its impossible really.

im tryna start this little side project, do really want to try fresh and v2 now instead of having to upgrade it much later.

steps to reproduce:
code here: repo, main branch is fresh v1, fresh v2 is on deno2 branch
ive deployed each branch to a deno deploy project, u can find the link in the gh actions on each branch if u wanna check the behaviour in the vids (i dont wanna post it here even tho the links already public, gcp will charge me $$ for sending email 😂)

https://github.com/user-attachments/assets/be1939ae-d162-4acb-bc03-1c06c4b836f7

https://github.com/user-attachments/assets/416ba967-b856-4221-aa5e-feb352ce4601

Lingua principale
TypeScript
Stelle
13.8k
Fork
757
Merge medio
3m
PR unite (30g)
2

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di freshframework/fresh

Tutte le issue di freshframework/fresh

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.