Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

[BUG][code-analyzer] sfge: Database.query() on a string that is empty on any path aborts the entry point ("Query should have fields")

Aperta
  • Qualcosa non va?
#2,104 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
72/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
java, typescript
Ambito
devtools, testing-qa

Direzione di ricerca

Start with SoqlParserUtil.java, especially extractFields and the existing handling of IllegalStateException; compare what happens when the field-pattern match fails. Run the sfge rule against the QueryEmptyOnOnePath reproducer and check that an empty query path no longer aborts analysis, while a real query path still reports the ApexFlsViolation for Account.Name.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Have you tried to resolve this issue yourself first?
  • I confirm I have gone through the above steps and still have an issue to report.
Bug Description

Engine: sfge (Salesforce Graph Engine) · Rule: ApexFlsViolation (DevPreview) · Selector: --rule-selector sfge

sfge parses the string passed to Database.query() with SoqlParserUtil.parseQuery. When the field pattern finds no match, extractFields throws:

// SoqlParserUtil.java:330-334
final Matcher fieldMatcher = FIELD_PATTERN.matcher(query);
if (!fieldMatcher.find()) {
    throw new UnexpectedException("Query should have fields: " + query);
}

A common way to build a dynamic query is to start from '' and assign the query in branches. sfge expands every path, including the one where no branch ran, and the string there is still ''. The throw on that one path abandons the whole entry point, so the paths with a real query are never checked for FLS either.

String query = '';
if (mode == 'all') {
    query = 'SELECT Id, Name FROM Account';
}
return Database.query(query);
Output / Logs
UnexpectedException: Query should have fields: :
com.salesforce.graph.ops.SoqlParserUtil.extractFields(SoqlParserUtil.java:333);
com.salesforce.graph.ops.SoqlParserUtil.parseFields(SoqlParserUtil.java:356);
com.salesforce.graph.ops.SoqlParserUtil.getSoqlQueryInfo(SoqlParserUtil.java:211);
com.salesforce.graph.ops.SoqlParserUtil.getInnerQueries(SoqlParserUtil.java:194);
com.salesforce.graph.ops.SoqlParserUtil.parseQuery(SoqlParserUtil.java:144);
com.salesforce.graph.symbols.apex.ApexSoqlValue.setObjectProperties(ApexSoqlValue.java:135)

The query after Query should have fields: is empty.

Steps To Reproduce
  1. Create an empty SFDX project (sfdx-project.json with a single force-app package directory).
  2. Add force-app/main/default/classes/QueryEmptyOnOnePath.cls with the class shown below, plus a standard QueryEmptyOnOnePath.cls-meta.xml (apiVersion 62.0).
  3. Add code-analyzer.yml: 
    engines:
  sfge:
    java_thread_timeout: 900000
    java_thread_count: 4
  4. Run: 
    sf code-analyzer run --rule-selector sfge --workspace . --config-file code-analyzer.yml
  5. The run reports an InternalExecutionError for the entry point instead of analysing it. The READ on Account.Name goes unreported, and nothing in the summary indicates coverage was lost.
public with sharing class QueryEmptyOnOnePath {
    @AuraEnabled
    public static List<Account> run(String mode) {
        String query = '';
        if (mode == 'all') {
            query = 'SELECT Id, Name FROM Account';
        }
        return Database.query(query);
    }
}
Expected Behavior

A query string that does not parse should leave that one path's query unresolved, the way sfge already reports "couldn't resolve the parameter passed to [READ] operation". It should not throw. extractFields already degrades to an empty field list on IllegalStateException, and a failed match could take the same route.

Operating System

macOS 26.7.1

Salesforce CLI Version

@salesforce/cli/2.147.7 darwin-arm64 node-v24.5.0

Code Analyzer Plugin (code-analyzer) Version

code-analyzer 5.15.0

Node Version

v24.5.0

Java Version

openjdk version "11.0.32" 2026-07-21

Python Version

N/A

Additional Context (Screenshots, Files, etc)

Also fails on code-analyzer 5.16.0 (sfge 0.25.0) under OpenJDK 21 on ubuntu-latest, with the same stack. In our codebase it abandons 1 @AuraEnabled entry point.

A control in the same workspace, with a non-empty query on every path (String query = 'SELECT Id, Name FROM Account';, overwritten in the branch), was analysed normally and reports the expected ApexFlsViolation for the READ on Account.Name.

#1224, closed in the 2026-06-30 pre-v5 sweep, failed at the same line with a different input: an inner query in a WHERE clause (Id NOT IN (INNER_QUERY) AND ...), which matches the TODO: Handle contents within brackets in getInnerQueries. We have not re-tested that input. A fix that degrades instead of throwing would cover both.

Workaround

Initialise the query string to a valid query, or return before Database.query() on the path that builds none.

Urgency

Moderate

Lingua principale
TypeScript
Stelle
241
Fork
51
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di forcedotcom/code-analyzer

Tutte le issue di forcedotcom/code-analyzer

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.