ssa/jsondiff: honor ignored fields before dry-run validation
I maintainer di solito rispondono entro 1 giorno
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 30/100
Direzione di ricerca
Start in ssa/jsondiff/unstructured.go, in Unstructured(), where the live object is fetched and the desired object is dry-run applied before ignored paths are removed. Read the existing tests for the ignore-path filtering, then decide how live values at ignored paths should be copied into a temporary desired object, including the missing-path and array cases. Done means a regression test where a validating webhook rejects a decrease of an ignored field now passes the dry-run, unrelated drift is still reported, and the error still returns without the rule. The semantics need maintainer agreement first.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Problem
jsondiff.Unstructured() applies ignored paths only after its server-side dry-run succeeds. An ignored field can therefore cause admission validation to reject the dry-run before the ignore rules take effect.
Reported downstream in https://github.com/fluxcd/helm-controller/issues/1613 with helm-controller v1.4.5 and a StackGres SGShardedCluster. The same ordering is present in ssa/v0.80.0.
Example
The downstream reporter ignores these fields because an in-cluster controller updates them after installation:
/spec/coordinator/pods/persistentVolume/size/spec/shards/pods/persistentVolume/size/spec/shards/overrides
When the live volume size is larger than the value in the Helm release manifest, the dry-run submits the smaller manifest value. The validating webhook rejects the attempted shrink, even though that field is ignored for drift detection. This prevents comparison and correction of unrelated fields on the resource.
This example comes from the downstream report; I have traced the code but have not independently reproduced it against StackGres.
Code path
Unstructured() first fetches the live resource, then copies the desired object and submits it with client.Apply and client.DryRunAll:
https://github.com/fluxcd/pkg/blob/ssa/v0.80.0/ssa/jsondiff/unstructured.go#L158-L166
Only after that succeeds does it remove ignored paths from the dry-run result and the live object before calculating the diff:
https://github.com/fluxcd/pkg/blob/ssa/v0.80.0/ssa/jsondiff/unstructured.go#L176-L186
The ordering has existed since the introduction of jsondiff in #657. The ApplyOptions.DriftIgnoreRules work in #1157 is a separate path; helm-controller calls jsondiff.UnstructuredList() directly.
Expected behavior / proposed approach
For existing resources, consider preserving live values at matching ignored paths in a temporary copy of the desired object before submitting the dry-run. Keep the existing post-dry-run filtering so ignored fields do not appear in the correction patch. The original desired object should remain unchanged, and missing resources should retain the full desired manifest for creation.
The semantics for paths missing from either object, array paths, and overlapping paths need to be defined and tested. Simply deleting ignored fields before server-side apply may affect required fields or field ownership, so it is not necessarily equivalent to preserving live values.
A regression test should use validation that rejects a decrease of an ignored field, verify that the dry-run succeeds with the rule, and verify that unrelated drift remains detectable and correctable. Without the rule, the validation error should still be returned.
Workaround
The downstream reporter disables drift detection for the entire resource with helm.toolkit.fluxcd.io/driftDetection: disabled, losing drift detection for its other fields.
- Lingua principale
- Go
- Stelle
- 63
- Fork
- 162
- Merge medio
- 9h 54m
- PR unite (30g)
- 29
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di fluxcd/pkg
-
ssa: wait errors drop the kstatus message, so health check failures don't say whyForse già presa @schdief l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 35/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 35/100
I maintainer di solito rispondono entro 1 giorno
-
Improve `make release` to support major version bumpsForse già presa @Iam-Karan-Suresh l’ha presa 175 giorni fa. Apertaarea/ci
fluxcd/pkg#1172 · 3 commenti · 1 reazione · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
-
Bug: `runtime/client.(*Impersonator).CanImpersonate` does not take kubeconfig into accountForse di nuovo libera @yuminn-k l’ha presa 16 giorni fa e non c’è nessuna pull request aperta. Aperta
Difficoltà 3/5 1-2 giorni Idoneità per principianti 49/100
I maintainer di solito rispondono entro 1 giorno
Issue simili
-
Pin and verify Security Insights schema in lintinsights targetForse già presa @imshubham22apr-gif l’ha presa 5 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
gemaraproj/gemara#618 ·
I maintainer di solito rispondono entro 2 giorni
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 64/100
a2aproject/a2a-go#597 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
I maintainer di solito rispondono entro 4 giorni
-
scopes: GetAllowedTopics, GetProtectedTopics, and GetScopedTopics include empty topic names and do not trim whitespace charactersForse già presa @patelshivani2283-lab l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
area/networking kind/bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 69/100
siderolabs/talos#14972 ·
I maintainer di solito rispondono entro 1 giorno