Keyboard-only daily loop of the admin, the WCAG 2.2 criteria axe-core does not check, and the screen reader pass (A-54)

Aperta
#3,460 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
csharp

Direzione di ricerca

Start with docs/planning/admin-technical-spec.md sections 2.3, 4.18, 7 and 10.8, then inspect the end-to-end tests and the named toast and field editor files. The issue depends on A-42 and includes keyboard coverage, WCAG checks, component fixes, and a screen reader script. Done means meeting the acceptance checklist and adding docs/admin-accessibility.md with the pass script.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:admin area:testing type:feature

Problem

axe-core (A-42) reads the markup of a page as it stands. It does not press a key, follow the focus or wait for a message, and section 7 asks for more than it gives: keyboard-only runs of the daily loop, and a manual screen reader pass (NVDA with Firefox, VoiceOver with Safari) before A7 ends. Section 4.18 names criteria that no test measures today:

  • Keyboard. The end-to-end cases press keys where a case needs them (Ui.PressAsync) and use the pointer for the rest. No case runs the loop of section 7 without a pointer, so a step that only a click reaches would not be found.
  • WCAG 2.2. Focus not hidden by a sticky header (2.4.11), a way without dragging for every drag (2.5.7), targets of 24 pixels (2.5.8), and reduced motion respected. Blocks and the entries of a relation are reordered by dragging (admin/src/FluentCMS.Admin/Fields/NestedFieldEditor.razor, Fields/RelationFieldEditor.razor), and A-26 gave blocks a reorder by keys, but no test lists the drags of the admin with the way around each.
  • Three faults of the wrapped set (#3178). An error toast dismisses itself after 7 seconds like the rest (WCAG 2.2.1), and its live region is created together with its content, which a screen reader may not read (admin/src/FluentCMS.Admin.Components/CmsToastService.cs); only the component gallery shows a toast today. A dialog and a drawer have no visible close button, and a dialog removed from the tree while open cannot return focus. The theme items of the user menu are plain items with a check icon, where menuitemradio with aria-checked is the pattern.
  • The screen reader pass has no script. It is the maintainer's part, and nothing says which steps to take, what should be heard at each, or where to record what was found.

Proposal

  • The loop by keyboard alone. One end-to-end class runs the loop of section 7 with no pointer event: sign in on the hosted page, find an article by search and by a filter, open it, change a text, a number, a date, a select, a relation and an image, write in the rich text editor with its toolbar, add and move a block, save, meet the conflict dialog, publish, schedule, open the preview and change its width, select entries and publish them in bulk, upload a file, sign out. On the way it asserts what 4.18 asks: the skip link, focus on the heading after a route change, focus inside a dialog and back on its opener, and no trap.
  • The criteria of WCAG 2.2, as checks over the list of views of A-42: after each Tab of the loop the focused element is not covered by a sticky part of the page; every target is 24 pixels or has the spacing the criterion allows; with reduced motion asked for, no transition or animation runs; at a width of 320 pixels a core page does not scroll sideways. A list in the specification names each drag of the admin with its way without dragging, and a case uses each.
  • The wrapped set. An error toast stays until dismissed, and every toast is announced through the shell's two live regions and not through one of its own. A dialog and a drawer have a visible close button with a name, and a dialog removed while open returns focus to its opener. The wrapped menu offers radio items, and the theme items use them.
  • The script of the screen reader pass, docs/admin-accessibility.md: the steps of the loop, what is to be heard at each (the name, the role, the state, the message of a live region), for NVDA with Firefox and for VoiceOver with Safari, and a table for the result of each step. What the pass finds is filed as a bug and fixed before the release (A-47).

Acceptance

  • The class runs the loop with no pointer event and fails when a step is made reachable by click alone
  • No focused element of the loop is covered by a sticky part, and each view passes the checks of target size, reduced motion and width
  • Each drag of the admin is in the list of the specification with its way without dragging, and a case uses it
  • An error toast stays until dismissed and is read once from the assertive region; a success toast is read once from the polite one
  • A dialog and a drawer close by a visible, named button, and focus returns to the opener, also when the dialog is removed while open
  • The theme items are menuitemradio with aria-checked, and a choice does not flip back
  • docs/admin-accessibility.md holds the script, and the tracking issue links the filled table once the maintainer has run it
  • The items of #3178 on toasts, on the dialog and the drawer, and on the theme items are ticked

Design: docs/planning/admin-technical-spec.md, sections 2.3, 4.18, 7 and 10.8 (A-54, split from A-42). Row 3.19. Takes three items of #3178. Needs A-42. The screen reader pass itself is the maintainer's part. Size: M.

Lingua principale
C#
Stelle
567
Fork
107
Merge medio
1h 19m
PR unite (30g)
353

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di fluentcms/FluentCMS

Tutte le issue di fluentcms/FluentCMS

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.