The prebuilt admin inside FluentCMS.Admin.Hosting, served without the app's project (A-55)
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 35/100
- Tipo di issue
- Funzionalità
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- csharp
- Ambito
- backend, build-system, developer-experience
Direzione di ricerca
Read docs/planning/admin-technical-spec.md sections 2.8, 6.1, 6.3 and 10.8, then inspect admin/src/FluentCMS.Admin.Hosting/AdminHostingExtensions.cs and the package check in eng/check-packages.cs. Start by testing whether packaged fingerprinted and compressed assets retain their endpoints; the issue calls for a one-day spike to choose the serving path. Done means the package-only host serves the admin and passes every listed acceptance check, including publish size and removal of icon assemblies.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Problem
AQ8 ships the static build twice: as a zip on the release (A-43), and inside FluentCMS.Admin.Hosting, so that a host that wants the first-party admin adds one package and MapFluentCmsAdmin(). The second does not exist:
- The package serves only what the host builds.
MapFluentCmsAdminserves the host's own static web assets and stops the host when it finds no{application}.staticwebassets.endpoints.json, with "The host references the admin app's project" (admin/src/FluentCMS.Admin.Hosting/AdminHostingExtensions.cs, lines 70 to 77). The package's README says the prebuilt app "comes later (AQ8)". - A host made from packages has no project to reference.
FluentCMS.Admin.Appis not a package (Directory.Build.props, lines 46 to 48), so the host ofdotnet new fluentcmscannot serve an admin, which row 11.1 and A-44 ask for. - Two follow-ups of the package (#3178). A host that references the app's project gets the component library's four icon assemblies in its publish root, 22.6 MB that arrive as NuGet runtime assets and that no server code loads. And a malformed
index.html, with no<base href>or two, stops the host withFCMS1103, titled "FluentCMS not registered".
Proposal
- The package carries the build.
FluentCMS.Admin.Hostingpacks the publishedwwwrootofFluentCMS.Admin.App, the same files as the zip of A-43, andMapFluentCmsAdminserves them when the host references no admin app. A host that references an app project of its own (thefluentcms-admintemplate, 6.2) serves that one, and the README says how each case is told apart. - One way of serving. The files are answered as today: fingerprinted files cached for good, the compressed copy by
Accept-Encoding,index.htmlwith its base set andconfig.jsonfrom configuration never cached, the fallback for client routes, the headers of 6.1. Two ways are open. As static web assets of the package,MapStaticAssetskeeps doing all of it, if a package can carry an app's fingerprinted and compressed assets with their endpoints. As plain files of the package beside the host's output, the package answers them itself and the checks of theComposejob on caching and encoding get a copy for this path. The lane takes the first if a spike of a day proves it, and the second otherwise. - The reference host keeps its project reference, since the image is built from source and one build gives both (6.1).
- The icon assemblies stay out of a host, whichever way it gets the app, and out of
deps.json. - A code of its own for an
index.htmlthe package cannot set the base of. - What it costs. The pull request records the size of the package and the time the publish adds to
dotnet pack, and the check of the packages (eng/check-packages.cs) asks that the package holdsindex.htmland the Blazor script.
Acceptance
- A host with
FluentCMS.Admin.Hostingas a package and no app project serves the admin at/admin: the page with its base,config.jsonfrom configuration, a fingerprinted file cached for good and in Brotli, and a client route on reload - A host that references an app project of its own serves that app, with a half the first-party build does not have
- The reference host and the image serve as before, and the
Composejob passes unchanged - The publish root of a host holds no
Microsoft.FluentUI.AspNetCore.Components.Icons.*assembly, anddeps.jsonnames none - An
index.htmlwithout a<base href>stops the host with a code and a title of its own - The
Packjob fails when the package lacks the build; the pull request states the package's size - The items of #3178 on the icon assemblies and on the code of a malformed
index.htmlare ticked
Design: docs/planning/admin-technical-spec.md, sections 2.8, 6.1, 6.3 and 10.8 (A-55, split from A-43); AQ8. Rows 10.2, 11.1. Takes two items of #3178. Needs A-43. A-44 needs it. Size: M.
- Lingua principale
- C#
- Stelle
- 567
- Fork
- 107
- Merge medio
- 1h 19m
- PR unite (30g)
- 353
Preparare l'ambiente
- Include un Dockerfile o un file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di fluentcms/FluentCMS
-
area:localization plugin type:bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
area:storage type:bug
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
I maintainer di solito rispondono entro 1 giorno
-
area:testing type:bug
Difficoltà 3/5 1-2 giorni Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno
-
area:api area:publishing type:feature
Difficoltà 4/5 3-5 giorni Idoneità per principianti 55/100
fluentcms/FluentCMS#3473 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
area:storage plugin type:bug
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di fluentcms/FluentCMS
Issue simili
-
fix(ocr): compile the Tesseract-free pipeline with Tokio runtimeForse già presa @Goldziher l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
priority:P2
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
-
lompotc silently drops Java/C# class members past 128 instead of erroring, as its header claimsApertabug sev-5 vm
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100
-
area:jobads-cv bug FE mvp P3
Difficoltà 2/5 1-3 ore Idoneità per principianti 77/100
klasolsson81/jobbliggaren#2271 ·
I maintainer di solito rispondono entro 1 giorno