Accessibility audit of the admin to WCAG 2.2 AA: axe-core checks of every page, in both themes and right to left (A-42)

Aperta
#3,458 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
csharp, github, playwright

Direzione di ricerca

Start with admin/tests/FluentCMS.Admin.EndToEnd and admin/tests/FluentCMS.Admin.Tests/AccessibilityTests.cs, then read sections 2.3, 4.18, 7 and 10.8 of docs/planning/admin-technical-spec.md. The issue depends on A-53 and A6, and requires an axe-core harness, route coverage, theme and RTL sweeps, exceptions, contrast fixes and CI integration. Done means every listed view passes or has a tracked exception, uncovered routes fail a test, and the acceptance checks and CI timing are recorded.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:admin area:testing type:feature

Problem

Row 3.19 sets WCAG 2.2 AA as the target, and section 7 asks for axe-core checks of each core page in both themes and in a right-to-left pseudo-culture. The repository has no axe-core harness: Directory.Packages.props names no such package, and section 5.1 records that the check of the home page waits for this issue. What exists checks behaviour, not markup:

  • Component tests of the focus after a route change, the skip link and the live regions (admin/tests/FluentCMS.Admin.Tests/AccessibilityTests.cs).
  • Keyboard steps inside the end-to-end cases, through Ui.PressAsync and Ui.FocusAsync (12 of the 22 test classes of admin/tests/FluentCMS.Admin.EndToEnd).
  • The acceptance line "usable by keyboard alone" of each page's issue.

Nothing measures names, roles, landmarks, the order of headings or contrast, page by page. By the end of A6 the pages are: the home page; the list and the form of a content type with every field editor, the rich text editor and the component and block editors; the relation picker and the media picker; the status, schedule and version panels; the preview pane; the bulk dialog; the media library, the asset detail and the presets; the account page; the nine areas of administration (users, roles, API keys, members, sites, plugins, jobs, diagnostics, settings); the pages of the webhooks, MCP, AI assist, multi-site and search halves; the component gallery and the plugin problems page; and the states without a page of their own: not found, no access, no site, the configuration error and the sign-in callback.

One fault is known. With an accent color set, 12 of the library's 57 brand tokens follow it, and the color on the accent is fixed white (admin/src/FluentCMS.Admin.Components/wwwroot/cms.css, line 13), so an accent of #ffd400 gives 1.43:1 on a primary button (#3178).

Proposal

  • The harness. Deque.AxeCore.Playwright 4.14.0 (AQ9) in the end-to-end project, behind one helper that runs axe-core on the page as it stands, with the rules tagged WCAG 2.0, 2.1 and 2.2 at levels A and AA, and fails with each violation's rule, its target and the address of its help page.
  • The sweep. A list of the views above, each with the steps that bring it to a state with content: a list with rows, a form of the Blog sample with each editor filled, a dialog or a panel open. Each view is checked in the light and the dark theme, and once more under ar-XB (A-53). A view added later joins the list or fails a test that compares the list with the routes of the app.
  • Exceptions in one place. A violation the admin cannot fix, inside a component of the library, is an entry of one list: the rule, the selector, the reason and the issue that tracks it. The list is the measure of the audit, and empty is the aim.
  • The fixes. A violation in the admin's own markup or in a wrapper is fixed in this issue. A fault that needs a design, or more than a day, gets an issue and an exception.
  • The accent. The states of a control follow the accent, and the color on the accent is black or white, whichever contrasts more, which reaches 4.5:1 for every accent. The branding sets it with the accent, through the property call of the allow-list.
  • Where it runs. In the End-to-end (admin) job of full CI, as classes of the same project, so the run on the image (A-45) takes them with no further work. The right-to-left run needs a host published with the pseudo-cultures.

Acceptance

  • The helper fails a page with a known violation, such as an image without a name, and names the rule and the element
  • Every view of the list passes in the light and the dark theme and under ar-XB, or has an exception with its reason and its issue
  • A route of the app that the list does not cover fails a test
  • A primary button meets 4.5:1 with an accent of #ffd400 and with one of #00205b, in both themes, and its hover and pressed states follow the accent
  • The specification names the exceptions that remain and records the time the sweep adds to the job
  • The item of #3178 on the accent color is ticked

Design: docs/planning/admin-technical-spec.md, sections 2.3, 4.18, 7 and 10.8 (A-42). Row 3.19. Adds Deque.AxeCore.Playwright 4.14.0 (AQ9). Takes one item of #3178. Needs A-53 for the right-to-left run, and A6 merged for its pages. A-54, which takes the keyboard-only loop and the screen reader pass of the row in 10.8, needs it. Size: M.

Lingua principale
C#
Stelle
567
Fork
107
Merge medio
1h 19m
PR unite (30g)
353

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di fluentcms/FluentCMS

Tutte le issue di fluentcms/FluentCMS

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.